-
Notifications
You must be signed in to change notification settings - Fork 747
feat(amazonq): allow child processes to define custom thresholds #7205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
jpinkney-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we get the benefit of the extension host not messing up our memory/cpu numbers in flare 🎉
| executable: executable, | ||
| serverModule, | ||
| execArgv: argv, | ||
| warnThresholds: { memory: memoryWarnThreshold }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the value here only 200MB because the workspace context part of the language-servers repo isn't doing the indexing? I guess once we fully enable inline through Flare we'd probably have to re-adjust these numbers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed up with local indexing team, and it looks like it was disabled in my testing since this requires pulling the indexing server. After enabling its using ~700-800MB so I'll bump this to 1GB to be safe.
3c6b048 to
c7e7a27
Compare
Problem
Some processes use significantly more cpu/memory than others, so we shouldn't hold them to the same static threshold.
As an example, the language servers are consistently using more memory than the 100 MB threshold.
Based on some experimentation with different sized workspaces, I've noticed that the process running agentic chat uses roughly 80MB-150MB of memory, and the workspace indexing uses 550 - 700 MB memory.
Solution
feature/xbranches will not be squash-merged at release time.