Skip to content

Conversation

@tomcat323
Copy link
Contributor

@tomcat323 tomcat323 commented May 8, 2025

Problem

We introduced editorState in data instrumentation launch. The service has a requirement of 40k character limit for the text field.

Solution

Implement a check on text length. If the text length exceeds 40k characters, section 20k max characters from the left and right side of current cursor position, so the final text is always less than 40k.

validated prod endpoint inline working for files > 40k characters.
Example request id: 57bbbe65-fbe7-47fc-81c4-c65262f47ce8


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tomcat323 tomcat323 requested a review from a team as a code owner May 8, 2025 01:18
@github-actions
Copy link

github-actions bot commented May 8, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@tomcat323 tomcat323 requested a review from a team as a code owner May 8, 2025 16:31
@tomcat323 tomcat323 merged commit 734bd98 into aws:master May 8, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants