Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

@jpinkney-aws jpinkney-aws commented May 8, 2025

Problem

the tutorial trackers aren't implemented when using the language server

Solution

  • re-add the inlineLineAnnotationController (inlineChatTutorialAnnotation) for adding hints with inline chat
  • re-add the lineAnnotationController (inlineTutorialAnnotation) for adding the inline suggestions tutorial

Notes

in a future PR I'll fully deprecate the old trackers


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested review from a team as code owners May 8, 2025 19:06
@github-actions
Copy link

github-actions bot commented May 8, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jpinkney-aws jpinkney-aws force-pushed the flare-state-tracker-2 branch from 478e8df to b3e195b Compare May 8, 2025 21:05
private lineTracker: LineTracker
private activeStateTracker: InlineGeneratingMessage
private incomingGeneratingMessage: InlineGeneratingMessage
private lineAnnotationTracker: LineAnnotationController
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: rename this to something like InlineTutorialAnnotation? I think naming this closer to the feature of how a user would describe it

@jpinkney-aws jpinkney-aws merged commit 0d2c7fb into aws:feature/flare-inline May 9, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants