Skip to content

Conversation

@ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented May 8, 2025

Problem

Inconsistent behavior when opening agent tabs (/review, /doc, etc). When the tab is reused it keeps the prompt input options visible, but when a new tab is created it doesn't.

tab.mov

Solution

Set promptInputOptions to empty when an existing tab is reused.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented May 8, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@ctlai95 ctlai95 marked this pull request as ready for review May 8, 2025 20:42
@ctlai95 ctlai95 requested a review from a team as a code owner May 8, 2025 20:42
Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, this is effectively just removing the toggle on the bottom left/right?

@ctlai95
Copy link
Contributor Author

ctlai95 commented May 8, 2025

Yes, and also model selection dropdown which is in progress here aws/language-servers#1294

@ctlai95 ctlai95 merged commit 8a02d60 into aws:master May 8, 2025
31 checks passed
@ctlai95 ctlai95 deleted the fix-tab-behavior branch May 8, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants