Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented May 8, 2025

This reverts commit 98b0d5d.

Problem

It regress #7181 and make 7181 not working: profile will be changed, but customization will be swapped to default always.

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner May 8, 2025 20:03
@github-actions
Copy link

github-actions bot commented May 8, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Will-ShaoHua Will-ShaoHua enabled auto-merge (squash) May 8, 2025 20:20
@Will-ShaoHua
Copy link
Contributor Author

/retryBuilds

@Will-ShaoHua Will-ShaoHua merged commit 529f833 into aws:master May 8, 2025
29 of 31 checks passed
@Will-ShaoHua Will-ShaoHua deleted the custom branch May 8, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants