refactor(clearcache): Delete the LSP cache dir #7361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes users MAY modify the LSP cache dir for reasons like development, and when we clear all user cache we want to ensure the LSP cache is not corrupted. So when the user calls the clear cache command from the command palette it will also clear the LSP cache too. Signed-off-by: nkomonen-amazon <[email protected]>
|
nkomonen-amazon
changed the title
opieter-aws
approved these changes
May 22, 2025
tomcat323
pushed a commit
to tomcat323/aws-toolkit-vscode
that referenced
this pull request
May 30, 2025
Sometimes users MAY modify the LSP cache dir for reasons like development. We have a feature to clear cache, but right now it does not clear the LSP cache. Now we will additionally clear the LSP cache when the user runs the command `Amazon Q: Clear extension cache` --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: nkomonen-amazon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes users MAY modify the LSP cache dir for reasons like development.
We have a feature to clear cache, but right now it does not clear the LSP cache.
Now we will additionally clear the LSP cache when the user runs the command
Amazon Q: Clear extension cachefeature/xbranches will not be squash-merged at release time.