fix(sso): increase SSO timeout #7367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
6 tasks
Contributor
Author
|
/retryBuilds |
Problem: In ticket V1761315147 it was being reported that createToken could take 9 seconds. This would mean that the SSO client API request would time out Solution: Bump the timeout to 12 seconds as specified in V1761315147 Signed-off-by: nkomonen-amazon <[email protected]>
nkomonen-amazon
force-pushed
the
ssoTimeout
branch
from
d005eaf to
5f2ebac
Compare
Hweinstock
approved these changes
May 23, 2025
tomcat323
pushed a commit
to tomcat323/aws-toolkit-vscode
that referenced
this pull request
Jun 5, 2025
## Problem: In ticket V1761315147 it was being reported that createToken could take 9 seconds. This would mean that the SSO client API request would time out ## Solution: Bump the timeout to 12 seconds as specified in V1761315147 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: nkomonen-amazon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In ticket V1761315147 it was being reported that createToken could take 9 seconds. This would mean that the SSO client API request would time out
Solution:
Bump the timeout to 12 seconds as specified in V1761315147
feature/xbranches will not be squash-merged at release time.