Skip to content

Conversation

@opieter-aws
Copy link
Contributor

Problem

Users are seeing telemetry: invalid Metric: "codewhisperer_clientComponentLatency" emitted without the resultproperty, which is always required. Consider using.run()instead of.emit(), which will set these properties automatically. See https://github.com/aws/aws-toolkit-vscode/blob/master/docs/telemetry.md#guidelines

Solution

Add result attribute when emitting the metric


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@opieter-aws opieter-aws marked this pull request as ready for review May 23, 2025 18:36
@opieter-aws opieter-aws requested a review from a team as a code owner May 23, 2025 18:36
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@opieter-aws opieter-aws merged commit 4535284 into aws:feature/flare-mega May 23, 2025
17 of 22 checks passed
tomcat323 pushed a commit to tomcat323/aws-toolkit-vscode that referenced this pull request Jun 5, 2025
## Problem
Users are seeing `telemetry: invalid Metric:
"codewhisperer_clientComponentLatency" emitted without the `result`
property, which is always required. Consider using `.run()` instead of
`.emit()`, which will set these properties automatically. See
https://github.com/aws/aws-toolkit-vscode/blob/master/docs/telemetry.md#guidelines`

## Solution
Add result attribute when emitting the metric

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants