Skip to content

Conversation

@justinmk3
Copy link
Contributor

Problem

LSP server can't open URLs, because the LSP client does not correctly handle ShowDocumentParams.external requests.
LSP spec: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#showDocumentParams

Solution

When ShowDocumentParams.external is true, open the URL in a web browser instead of as a editor document.

Also: avoid PII in openUrl metric.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

justinmk3 added 2 commits June 2, 2025 11:19
Problem:
LSP server can't open URLs, because the LSP client does not correctly
handle `ShowDocumentParams.external` requests.
LSP spec: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#showDocumentParams

Solution:
When `ShowDocumentParams.external` is true, open the URL in a web
browser instead of as a editor document.
@justinmk3 justinmk3 requested a review from a team as a code owner June 2, 2025 18:55
@github-actions
Copy link

github-actions bot commented Jun 2, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@justinmk3 justinmk3 enabled auto-merge (squash) June 2, 2025 19:00
@justinmk3 justinmk3 disabled auto-merge June 2, 2025 19:00
@justinmk3 justinmk3 enabled auto-merge June 2, 2025 19:01
@justinmk3 justinmk3 disabled auto-merge June 3, 2025 15:21
@justinmk3 justinmk3 merged commit 25ec061 into aws:master Jun 3, 2025
30 of 31 checks passed
@justinmk3 justinmk3 deleted the fixes branch June 3, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant