Skip to content

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Jun 12, 2025

Problem

String comparison says "1.11.0" < "1.9.0". We should compare numbers.

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner June 12, 2025 17:58
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@leigaol leigaol changed the title fix: bundle flare version comparison fix(amazonq): bundle flare version comparison Jun 12, 2025
@laileni-aws laileni-aws reopened this Jun 12, 2025
@leigaol leigaol changed the title fix(amazonq): bundle flare version comparison fix(amazonq): bundle flare version comparison using numbers Jun 12, 2025
@laileni-aws laileni-aws enabled auto-merge (squash) June 12, 2025 18:25
@laileni-aws
Copy link
Contributor

/retryBuilds

Copy link
Contributor

@bryceitoc9 bryceitoc9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use semver.compare?

@leigaol
Copy link
Contributor Author

leigaol commented Jun 12, 2025

Why not use semver.compare?

I was under the impression that build script should be standalone. But then I tried to import semver and it works.
This code is not checked in the extension code so I cannot use logger.info() etc..

@laileni-aws
Copy link
Contributor

/retryBuilds

@laileni-aws laileni-aws merged commit ec58764 into aws:master Jun 12, 2025
33 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants