-
Notifications
You must be signed in to change notification settings - Fork 747
fix(amazonq): chatOptions are missing in q chat #7520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kmile
approved these changes
Jun 18, 2025
ashishrp-aws
approved these changes
Jun 19, 2025
chungjac
approved these changes
Jun 19, 2025
ctlai95
approved these changes
Jun 19, 2025
laileni-aws
added a commit
to laileni-aws/aws-toolkit-vscode
that referenced
this pull request
Jun 19, 2025
laileni-aws
added a commit
that referenced
this pull request
Jun 19, 2025
## Notes: - Adding change log for #7520 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chatOptionslike mcp icon, history icon, export icon in tab bar and quickActions like/clearand/helpin the input menu.Root Cause 1:
CHAT_OPTIONScommand is sometimes not properly received by the handleInboundMessage function in the chat client.onDidResolveWebviewevent fired, the code was immediately trying to send a message to the webview, but in some cases, the webview wasn't fully ready to receive messages yet, causing the message to be lost.Root Cause 2:
chatOptionslike quickActions(/helpor/clear) and tab bar icons are not sent because of webview delay.Ideal case:
messages.ts,chatOptionsare sent to the webview using webview.postMessage() with the command CHAT_OPTIONS and this is handled by thehandleInboundMessageinLS/chat.tsfile.Solution:
aws/chat/readyevent, which ensures we only send messages when the UI is fully initialized and ready to process them.aws/chat/readyevent is received from the UI.feature/xbranches will not be squash-merged at release time.