Skip to content

Conversation

@BlakeLazarine
Copy link
Contributor

@BlakeLazarine BlakeLazarine commented Jun 20, 2025

Problem

We want the agentic reviewer flow to be consistent with existing /review flow and populate the code issues panel.

Also store the findings in a uniquely named file so it can be accessed by the agent

Solution

Intercept the message coming from the language server to populate the code issues panel.

image


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@BlakeLazarine BlakeLazarine requested review from a team as code owners June 20, 2025 21:45
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

blakelaz-amazon and others added 25 commits June 20, 2025 15:48
feat(amazonq): improve the explain functionality
feat(amazonq): update findings bar
- Fix merge conflict in settings-toolkit.gen.ts
- Added amazonqLSPNEP experiment setting alongside existing amazonqLSPInlineChat
CodeWhispererConstants.amazonqIgnoreNextLine
)
)
// SecurityIssueProvider.instance.cleanOldFiles()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this comment

await generateFix.execute(targetIssue, targetFilePath, 'webview', true, false)
}
// if (targetIssue.suggestedFixes.length === 0) {
// await generateFix.execute(targetIssue, targetFilePath, 'webview', true, false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

const targetSource: Component = issue instanceof IssueItem ? 'tree' : source
const updatedIssue = await rejectFix.execute(targetIssue, targetFilePath)
await generateFix.execute(updatedIssue, targetFilePath, targetSource, true)
// const targetIssue: CodeScanIssue | undefined = issue instanceof IssueItem ? issue.issue : issue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants