-
Notifications
You must be signed in to change notification settings - Fork 747
feat(amazonq): Support receiving findings message from flare #7535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
…when lines are modified.
feat(amazonq): improve the explain functionality
feat(amazonq): update findings bar
- Fix merge conflict in settings-toolkit.gen.ts - Added amazonqLSPNEP experiment setting alongside existing amazonqLSPInlineChat
Code review tool
| CodeWhispererConstants.amazonqIgnoreNextLine | ||
| ) | ||
| ) | ||
| // SecurityIssueProvider.instance.cleanOldFiles() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove this comment
| await generateFix.execute(targetIssue, targetFilePath, 'webview', true, false) | ||
| } | ||
| // if (targetIssue.suggestedFixes.length === 0) { | ||
| // await generateFix.execute(targetIssue, targetFilePath, 'webview', true, false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
| const targetSource: Component = issue instanceof IssueItem ? 'tree' : source | ||
| const updatedIssue = await rejectFix.execute(targetIssue, targetFilePath) | ||
| await generateFix.execute(updatedIssue, targetFilePath, targetSource, true) | ||
| // const targetIssue: CodeScanIssue | undefined = issue instanceof IssueItem ? issue.issue : issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Problem
We want the agentic reviewer flow to be consistent with existing /review flow and populate the code issues panel.
Also store the findings in a uniquely named file so it can be accessed by the agent
Solution
Intercept the message coming from the language server to populate the code issues panel.
feature/xbranches will not be squash-merged at release time.