Skip to content

Conversation

@samgst-amazon
Copy link
Contributor

Problem

Previous fix was separate from the existing proxyUtil.ts handling.

Solution

Logic has been moved form platform.ts to proxyUtil.ts to have all process.env handling in one place.
also added fetching for NO_PROXY settings from vsc

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@samgst-amazon samgst-amazon requested a review from a team as a code owner June 23, 2025 21:28
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@samgst-amazon samgst-amazon enabled auto-merge June 24, 2025 22:01
@samgst-amazon samgst-amazon merged commit eaf969c into master Jun 24, 2025
31 checks passed
@samgst-amazon samgst-amazon deleted the samgst/no-proxy-setting branch June 24, 2025 22:22
* Sets environment variables based on proxy configuration
*/
private static setProxyEnvironmentVariables(config: ProxyConfig): void {
private static async setProxyEnvironmentVariables(config: ProxyConfig): Promise<void> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants