Skip to content

fix(amazonq): remove the depedency of the CDN js script #7586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(amazonq): remove the depedency of the CDN js script #7586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/core/scripts/build/copyFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ const tasks: CopyTask[] = [
{ target: path.join('src', 'testFixtures') },
{ target: 'src/auth/sso/vue' },

// Vue.js for webviews
{
target: path.join('../../node_modules', 'vue', 'dist', 'vue.global.prod.js'),
destination: path.join('libs', 'vue.min.js'),
},
// SSM
{
target: path.join('../../node_modules', 'aws-ssm-document-language-service', 'dist', 'server.js'),
Expand Down
6 changes: 5 additions & 1 deletion packages/core/src/login/webview/commonAuthViewProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@ export class CommonAuthViewProvider implements WebviewViewProvider {
const entrypoint =
serverHostname !== undefined ? Uri.parse(serverHostname).with({ path: `/${this.source}` }) : scriptUri

// Get Vue.js from dist/libs directory
const vueUri = Uri.joinPath(assetsPath, 'dist', 'libs', 'vue.min.js')
const vueScript = webview.asWebviewUri(vueUri)

return `
<!DOCTYPE html>
<html lang="en">
Expand All @@ -158,7 +162,7 @@ export class CommonAuthViewProvider implements WebviewViewProvider {
<title>Base View Extension</title>
</head>
<body>
<script src="https://cdnjs.cloudflare.com/ajax/libs/vue/3.4.4/vue.global.prod.min.js"></script>
<script src="${vueScript.toString()}"></script>
<script>
const vscode = acquireVsCodeApi();
</script>
Expand Down
Loading