Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Jul 20, 2025

Problem

by design, the code path should only be applied to "new" users, however currently it's taking 250ms for all users no matter the UI is displayed or not.

image

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner July 20, 2025 04:26
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Will-ShaoHua Will-ShaoHua changed the title config: disable inline tutorial since it's taking ~250ms for all users no matter it's shown or not config(amazonq): disable inline tutorial since it's taking ~250ms for all users no matter it's shown or not Jul 20, 2025
const isInlineEdit = result.items.some((item) => item.isInlineEdit)

// TODO: question, is it possible that the first request returns empty suggestion but has non-empty next token?
if (result.partialResultToken) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in other words, should it be

if (result.suggestions.length && result.partialResultToken) {
 // pull subsequent suggeestions
}

@Will-ShaoHua
Copy link
Contributor Author

/retryBuilds

@Will-ShaoHua Will-ShaoHua merged commit 7f36a2d into aws:master Jul 24, 2025
29 of 31 checks passed
@Will-ShaoHua Will-ShaoHua deleted the disable-inline-tutorial branch July 24, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants