feat(amazonq): UI Tests Baseline Framework Complete Set Up #7727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as webpack.NormalModuleReplacementPlugin that needed to be there in order for the amazonq to compile
…he checks. have to commit to check since the build compiles with no errors
…e tests are done running
…lkit-vscode into feature/ui-e2e-tests
…s to handle mynah overlays
laura-codess
changed the title
Hweinstock
reviewed
Jul 22, 2025
Contributor
|
From discussion, if one test fails we likely want some kind of general clean up util to ensure all the others don't. This may just be a reload window command? Might require some experimentation. |
Contributor
|
Don't see any blockers. I think the clean up can be done as a follow-up since atm I believe one test failing could cause the rest to fail. |
Hweinstock
approved these changes
Jul 22, 2025
| throw new Error('No selectable login options found') | ||
| } | ||
|
|
||
| const companyItem = await findItemByText(selectableItems, 'Company account') |
Contributor
There was a problem hiding this comment.
Why not do all of these without the varaiable assignment. Its making it hard to read.
Contributor
There was a problem hiding this comment.
is this what you're suggesting?
Suggested change
| const companyItem = await findItemByText(selectableItems, 'Company account') | |
| await findItemByText(selectableItems, 'Company account').click(); |
Contributor
There was a problem hiding this comment.
i think having it in two lines is more readable
Contributor
There was a problem hiding this comment.
We had an internal discussion. Spaces and comments should do it.
avi-alpert
approved these changes
Jul 22, 2025
abhraina-aws
approved these changes
Jul 22, 2025
laura-codess
merged commit 97397a8
into
aws:feature/ui-e2e-tests
31 of 37 checks passed
laura-codess
added a commit
to laura-codess/aws-toolkit-vscode
that referenced
this pull request
Aug 10, 2025
## Change This is a large PR for all the baseline setup of the framework. It includes the auth, setup, 4 test suites and the abstractions for each, and the cleanup functions. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
laura-codess
added a commit
to laura-codess/aws-toolkit-vscode
that referenced
this pull request
Aug 11, 2025
This is a large PR for all the baseline setup of the framework. It includes the auth, setup, 4 test suites and the abstractions for each, and the cleanup functions. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This is a large PR for all the baseline setup of the framework. It includes the auth, setup, 4 test suites and the abstractions for each, and the cleanup functions.
feature/xbranches will not be squash-merged at release time.