Skip to content

Conversation

@roger-zhangg
Copy link
Member

Problem

This change has no customer facing impact.
duration -> sessionDuration (correct)
Previously this metrics is wrongly recorded to duration and got overwritten by the metrics wrapper

Solution

Change to use sessionDuration correctly


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

duration -> sessionDuration (correct)
@roger-zhangg roger-zhangg requested a review from a team as a code owner July 21, 2025 20:46
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@roger-zhangg roger-zhangg changed the title fix(lambda): nit to use sessionDuration correctly for debug duration telemetry(lambda): nit to use sessionDuration correctly for debug duration Jul 21, 2025
@laileni-aws laileni-aws enabled auto-merge (squash) July 21, 2025 20:51
auto-merge was automatically disabled July 22, 2025 18:26

Pull request was closed

@roger-zhangg roger-zhangg reopened this Jul 22, 2025
@laileni-aws laileni-aws merged commit 2fb0926 into aws:master Jul 22, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants