-
Notifications
You must be signed in to change notification settings - Fork 747
feat(stepfunctions): Start Execution launching Execution Details #7741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions): Start Execution launching Execution Details #7741
Conversation
|
anthonyting
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we instead mimic the console experience? i.e. by default it replaces the current tab, and an option to open in a new tab?
My suggestion is to keep it as is, and once we connected the |
zelzhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you will need to include a changelog for this change.
packages/toolkit/.changes/next-release/Feature-eb3fdb2e-b75b-4789-8b2f-e18130aa1ccf.json
Outdated
Show resolved
Hide resolved
packages/toolkit/.changes/next-release/Feature-eb3fdb2e-b75b-4789-8b2f-e18130aa1ccf.json
Outdated
Show resolved
Hide resolved
laileni-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for adding demo video
e75caf3
into
aws:feature/stepfunctions-execution
Problem
Currently Start Execution only outputs the execution arn to the output
Solution
Adding a call to execution detail provider after starting an execution, launching the execution details webview ( Also works with express executions )
Verification
feature/xbranches will not be squash-merged at release time.