Skip to content

fix(amazonq): bring back timeout to local LSP call inline completion #7780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

fix(amazonq): bring back timeout to local LSP call inline completion #7780

merged 1 commit into from
Aug 1, 2025

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Jul 28, 2025 •
edited
Loading

Problem

During the inline completion migration to Flare, the timeout handling of inline completion API was lost. It was there in earlier versions. The IDE -> Flare call is a local network call that should have a timeout.

Solution

Add the inline completion call with timeout back. See https://github.com/aws/aws-toolkit-vscode/blob/amazonq/v1.74.0/packages/core/src/codewhisperer/util/commonUtil.ts#L21

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Jul 28, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@leigaol leigaol changed the title fix(amazonq): add timeout to local LSP call inline completion fix(amazonq): bring back timeout to local LSP call inline completion Jul 28, 2025
@rli rli closed this Jul 28, 2025
@rli rli reopened this Jul 28, 2025
@rli rli requested a review from a team as a code owner July 28, 2025 23:43
@leigaol
Copy link
Contributor Author

leigaol commented Jul 29, 2025

/retryBuilds

@leigaol leigaol merged commit 187f27a into aws:master Aug 1, 2025
57 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Will-ShaoHua Will-ShaoHua Will-ShaoHua approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leigaol @Will-ShaoHua @rli