feat(amazonq): Implement the MCP Abstractions and 3 Tests #7791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Change I added the gitignore fix --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
Hweinstock
reviewed
Aug 1, 2025
Contributor
Hweinstock
left a comment
Hweinstock
left a comment
There was a problem hiding this comment.
This test really shows me that we should try to get those testIds from Mynah because this logic is already getting pretty messy. Nice work handling all that mess and abstracting it away from the core test logic!
Hweinstock
reviewed
Aug 4, 2025
Hweinstock
approved these changes
Aug 4, 2025
laura-codess
added a commit
to laura-codess/aws-toolkit-vscode
that referenced
this pull request
Aug 10, 2025
## Change I implemented the abstractions for the MCP Server Test Suite, the functions include: clickToolsButton() clickMCPAddButton() configureMCPServer + various nested functions saveMCPServerConfiguration cancelMCPServerConfiguration clickMCPRefreshButton clickMCPCloseButton Along with the abstractions, I implemented 3 tests: [Test Amazon Q MCP Servers and Built-in Tools Access](https://quip-amazon.com/prX5ATmJnTQH/Test-Amazon-Q-MCP-Servers-and-Built-in-Tools-Access#temp:C:PMb1a32b1fc4eda47c49fcf1e311) [Add New MCP Server](https://quip-amazon.com/zixVAly68agD/Add-a-new-MCP-server#temp:C:BZRc2917aff34e4481da2d27633e) [Refresh MCP Server](https://quip-amazon.com/FfIOAYVC0Nm2/Refresh-MCP-Server#temp:C:UVL3c9fcca6b4bf447687a131a1e) I verified that the test works with all other webview based test suites (as of now the inline completion test is still being fixed) <img width="487" height="630" alt="Screenshot 2025-07-31 at 3 29 48 PM" src="https://github.com/user-attachments/assets/e0e50be6-ed85-4f21-9c7d-46371ee27cd2" /> --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
I implemented the abstractions for the MCP Server Test Suite, the functions include:
clickToolsButton()
clickMCPAddButton()
configureMCPServer + various nested functions
saveMCPServerConfiguration
cancelMCPServerConfiguration
clickMCPRefreshButton
clickMCPCloseButton
Along with the abstractions, I implemented 3 tests:
Test Amazon Q MCP Servers and Built-in Tools Access
Add New MCP Server
Refresh MCP Server
I verified that the test works with all other webview based test suites (as of now the inline completion test is still being fixed)
feature/xbranches will not be squash-merged at release time.