Skip to content

fix(amazonq): add back line numbers next to code issue #7810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 27, 2025
Merged

fix(amazonq): add back line numbers next to code issue #7810

merged 5 commits into from
Aug 27, 2025

Conversation

BlakeLazarine
Copy link
Contributor

@BlakeLazarine BlakeLazarine commented Aug 4, 2025 •
edited
Loading

Problem

There was previously a task "Remove [Ln 34, Col 1] from Code Issues panel from each issue". Originally, this was meant to just mean remove , Col 1`, but I interpreted it to mean remove the whole blob.

Solution

This change adds the line back, but without the , Col 1

image
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@BlakeLazarine BlakeLazarine requested a review from a team as a code owner August 4, 2025 17:27
@amazon-inspector-ohio Amazon Inspector (Ohio)
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio Amazon Inspector (Ohio)
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@laileni-aws
Copy link
Contributor

nit:
I think we can refactor these two functions

Not a blocker for this PR but please followup on this

@BlakeLazarine BlakeLazarine reopened this Aug 4, 2025
@amazon-inspector-ohio Amazon Inspector (Ohio)
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio Amazon Inspector (Ohio)
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@chungjac chungjac merged commit 764f30b into aws:master Aug 27, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmithsz tsmithsz tsmithsz approved these changes

@laileni-aws laileni-aws laileni-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BlakeLazarine @laileni-aws @tsmithsz @chungjac @blakelaz-amazon