Skip to content

fix(sagemaker): Add code-editor subdomain to refreshUrl #7826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Oct 13, 2025
Merged

fix(sagemaker): Add code-editor subdomain to refreshUrl #7826

merged 17 commits into from
Oct 13, 2025

Conversation

@aws-asolidu
Copy link
Contributor

@aws-asolidu aws-asolidu commented Aug 6, 2025

Problem

-All space reconnection redirect links were hardcoded to route users to the JupyterLab details page, due to a bug in the Studio web application.

Solution

  • With the bug now fixed in SageMaker Studio, we can support redirecting to the Code Editor details page via refreshUrl.
  • For backward compatibility, the default remains set to JupyterLab. Once the fix is verified and rolled out across all regions, we can remove the default behavior and instead explicitly check for the appType (e.g., JupyterLab) before setting the redirect.
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aws-asolidu aws-asolidu requested a review from a team as a code owner August 6, 2025 15:02
@amazon-inspector-ohio
Copy link

amazon-inspector-ohio bot commented Aug 6, 2025

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

github-actions bot commented Aug 6, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

amazon-inspector-ohio bot commented Aug 6, 2025

✅ I finished the code review, and didn't find any security or code quality issues.

@laileni-aws laileni-aws enabled auto-merge (squash) October 13, 2025 22:00
@laileni-aws laileni-aws merged commit 87c4eb8 into aws:master Oct 13, 2025
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laileni-aws laileni-aws laileni-aws approved these changes

@ashishrp-aws ashishrp-aws ashishrp-aws approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aws-asolidu @laileni-aws @ashishrp-aws @NewtonDer