fix(amazonq): edit diff UI doesnt render correctly when the diff contains only space char or empty line #7922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… space char or empty line
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Will-ShaoHua
changed the title
atonaamz
reviewed
Aug 19, 2025
| originalCodeHighlightRange: [], | ||
| } | ||
|
|
||
| const defaultLineHighlightLength = 4 |
Contributor
There was a problem hiding this comment.
why do we choose this number? This means 4 spaces are highlighted?
Contributor
Author
There was a problem hiding this comment.
since we can only do a static rendering afaik, and the number 4 is alignment with product
andrewyuq
approved these changes
Aug 19, 2025
atonaamz
approved these changes
Aug 19, 2025
leigaol
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The suggestion indicates the empty line (L4) is edited and replaced with suggestion content however there is no diff highlight. Reason behind is because the function
diffWordsWithSpacewill not say the line is removed (since it's be edited). https://github.com/aws/aws-toolkit-vscode/blob/master/packages/amazonq/src/app/inline/EditRendering/svgGenerator.ts#L437-L441Solution
feature/xbranches will not be squash-merged at release time.