Skip to content

fix(amazonq): add flag in settings for controlling experimental proxy support #7923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

fix(amazonq): add flag in settings for controlling experimental proxy support #7923

merged 1 commit into from
Aug 20, 2025

Conversation

@tsmithsz
Copy link
Contributor

@tsmithsz tsmithsz commented Aug 18, 2025 •
edited
Loading

Problem

The proxy and certificate auto-discovery code occasionally causes issues and there is a need to allow control of this by users.

Solution

Add a checkbox in settings that allow customers to control whether they want Amazon Q's proxy and certificate auto-discovery turned on.

Testing

Experimental proxy util used once setting enabled:

Screenshot 2025-08-19 at 10 49 11 AM

Standard proxy util used once setting disabled:

Screenshot 2025-08-19 at 10 50 05 AM
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tsmithsz tsmithsz requested a review from a team as a code owner August 18, 2025 23:26
@amazon-inspector-ohio
Copy link

amazon-inspector-ohio bot commented Aug 18, 2025

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

github-actions bot commented Aug 18, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

amazon-inspector-ohio bot commented Aug 18, 2025

✅ I finished the code review, and didn't find any security or code quality issues.

@tsmithsz tsmithsz changed the title fix(amazonq): add flag in setting for controlling experimental proxy … fix(amazonq): add flag in settings for controlling experimental proxy support Aug 18, 2025
laileni-aws
laileni-aws reviewed Aug 19, 2025
View reviewed changes
@bywang56 bywang56 merged commit 4dfb659 into aws:master Aug 20, 2025
45 of 46 checks passed
@tsmithsz tsmithsz deleted the settings-flag branch August 20, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laileni-aws laileni-aws laileni-aws approved these changes

@chungjac chungjac chungjac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tsmithsz @laileni-aws @chungjac @bywang56