feat(cloudformation): Merge CloudFormation LSP integration with toolkit updates #8275

kddejong · 2025-11-10T01:52:19Z

Add comprehensive CloudFormation Language Server Protocol support
Include CloudFormation explorer with stack management capabilities
Add stack deployment, validation, and change set workflows
Include SageMaker UX improvements and Amazon Q inline notifications
Update package dependencies and configurations

Problem

Solution

Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
Your code changes must meet the guidelines in CONTRIBUTING.md.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions · 2025-11-10T01:52:45Z

This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
- Note: beta or "experiment" features that have active users should announce fixes in the changelog.
- If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

- Add CloudFormation Language Server Protocol support with multiple provider options - Include CloudFormation explorer with stack, resource, and change set management - Add stack deployment, validation, and change set workflows with S3 upload support - Include drift detection and diff visualization capabilities - Add CloudFormation environment and project management with cfn-init integration - Include telemetry and authentication handling - Add comprehensive test coverage for all CloudFormation features - Update package configurations and language syntax highlighting

laileni-aws

For the next time,
can we please raise short PR at regular intervals which will be easy to review!

Reviewing 114 files and 13K+ lines of code is tough and time consuming!

Thank you.

laileni-aws · 2025-11-11T21:28:01Z

packages/core/src/awsService/cloudformation/cfn-init/cfnEnvironmentManager.ts

+        return path.join(workspaceRoot, this.cfnProjectPath, this.environmentsDirectory, environmentName)
+    }
+
+    private async getConfigPath(): Promise<string> {


nit: we can move this to shared/utils

Will move to shared/utils

laileni-aws · 2025-11-11T21:38:26Z

packages/core/src/awsService/cloudformation/commands/cfnCommands.ts

+        const result = await resourcesManager.searchResource(node.label as string, identifier)
+
+        if (result.found) {
+            void window.showInformationMessage(`Resource found: ${identifier}`)


Did we get sign off on these strings?
I guess we can be more elaborate on this information message or error message

I believe our UX/Product has synced up with ToolKit team members to get confirmation on what we will show to customers

Can you cross check on this ?
Thanks

We received fit and finish approval today and this was one of the messages that was demonstrated. No issues raised.

laileni-aws · 2025-11-11T21:41:45Z

packages/core/src/awsService/cloudformation/commands/environmentCommands.ts

+import { CloudFormationExplorer } from '../explorer/explorer'
+import { commandKey } from '../utils'
+
+export function selectEnvironmentCommand(explorer: CloudFormationExplorer): vscode.Disposable {


Do we need separate files for each command ? Instead we can have a single file like command.ts and include all commands inside and export them!

We can consolidate to one commands file

laileni-aws · 2025-11-11T21:43:38Z

packages/core/src/awsService/cloudformation/documents/documentPreview.ts

+
+const DocumentPreviewNotification = new NotificationType<DocumentPreviewType>('aws/document/preview')
+
+export class DocumentPreview {


This can be shared utils function!

Unless other parts of ToolKit needs this feature, is it worth moving it to the shared/utils?

This is commonly used to show the preview but not a blocker for sure

laileni-aws · 2025-11-11T22:30:01Z

packages/core/src/awsService/cloudformation/telemetryOptIn.ts

+    const message =
+        'Help us improve the AWS CloudFormation Language Server by sharing anonymous telemetry data with AWS. You can change this preference at any time in aws.cloudformation Settings.'
+
+    const allow = 'Yes, Allow'


nit: can improve readability

const THIRTY_DAYS_MS = 30 * 24 * 60 * 60 * 1000 const TELEMETRY_LEARN_MORE_URL = 'github.com/aws-cloudformation/cloudformation-languageserver/tree/main/src/telemetry' interface TelemetryPromptOptions { allow: string later: string never: string learnMore: string } const PROMPT_OPTIONS: TelemetryPromptOptions = { allow: 'Yes, Allow', later: 'Not Now', never: 'Never', learnMore: 'Learn More' } const TELEMETRY_MESSAGE = 'Help us improve the AWS CloudFormation Language Server by sharing anonymous telemetry data with AWS. ' + 'You can change this preference at any time in aws.cloudformation Settings.' ```

…ents - Remove resource type from list using right click - Few startup fixes for CloudFormation extension - Add exec permissions and support node versions - Add node to AWS Explorer CFN panel - Add prompt for deploymentMode and plumb to deployment - Coordinate stack views and add overview to CFN console - Fix extract to parameter cursor command

…ents * Remove resource type from list using right click * Few startup fixes for CloudFormation extension * Add exec permissions and support node versions * Add node to AWS Explorer CFN panel * Add prompt for deploymentMode and plumb to deployment * Coordinate stack views and add overview to CFN console * Fix extract to parameter cursor command

laileni-aws · 2025-11-11T23:05:59Z

packages/core/src/awsService/cloudformation/ui/diffViewHelper.ts

+        try {
+            const data = JSON.parse(context)
+            const pathParts = path.split('/').filter(Boolean)
+            let current: any = data


nit:
Datatype is JSON

laileni-aws · 2025-11-11T23:09:13Z

packages/core/src/awsService/cloudformation/ui/inputBox.ts

+    )?.value
+}
+
+export async function getImportExistingResources(): Promise<boolean | undefined> {


Can we reuse above getIncludeNestedStacks function ?

laileni-aws · 2025-11-11T23:20:21Z

packages/core/src/lambda/explorer/cloudFormationNodes.ts

+                if (nodeA instanceof AWSCommandTreeNode) {
+                    return -1
+                }
+                if (nodeB instanceof AWSCommandTreeNode) {


if ( nodeA instanceof AWSCommandTreeNode || nodeB instanceof AWSCommandTreeNode) { return 1 }

laileni-aws · 2025-11-11T23:23:44Z

packages/core/src/test/awsService/cloudformation/cfn-init/cfnEnvironmentManager.test.ts

+                label: 'test-profile',
+                state: 'valid',
+            } as any,
+        } as any


dataType: sinon.SinonStubbedInstance

Will make updates to the tests

laileni-aws · 2025-11-11T23:26:07Z

packages/toolkit/.changes/next-release/feature-cloudformation-lsp-integration.json

@@ -0,0 +1,4 @@
+{
+	"type": "Feature",
+	"description": "CloudFormation: Add comprehensive Language Server Protocol integration with stack management, deployment workflows, drift detection, and cfn-init project support"


If required we can add multiple change logs.

laileni-aws

Need to work on some nits and code refactoring but NOT a blocker for RIV:2025

manodnyab · 2025-11-12T18:51:05Z

packages/core/src/awsService/cloudformation/auth/credentials.ts

+        await this.updateCredentialsFromActiveConnection()
+    }
+
+    private async updateCredentialsFromActiveConnection(): Promise<void> {


will this always send the credentials or only when the feature is used?

Its hard to say if the feature is being used, because there are a lot of just UI elements visualizing their resources. Which requires sending credentials to load, they might not interact with the UI other than just viewing.
This will send the credentials anytime it changes, as long as the LSP is active

manodnyab · 2025-11-12T18:53:36Z

packages/core/src/awsService/cloudformation/cfn-init/cfnEnvironmentManager.ts

+    }
+
+    public async getEnvironmentDir(environmentName: string): Promise<string> {
+        const workspaceRoot = workspace.workspaceFolders?.[0]?.uri.fsPath


nit: this can be moved to a util function

Will move to a util function

manodnyab · 2025-11-12T18:54:39Z

packages/core/src/awsService/cloudformation/cfn-init/cfnInitCliCaller.ts

+    parametersFiles?: string[]
+}
+
+export class CfnInitCliCaller {


is this calling a dependency?

Yes, the dependency is located inside the server code.

manodnyab · 2025-11-12T18:56:10Z

packages/core/src/awsService/cloudformation/cfn-init/cfnInitUiInterface.ts

+        await progress
+        void vscode.window.showInformationMessage(`CFN project '${this.state.projectName}' created!`)
+
+        const openProject = await vscode.window.showQuickPick(['Yes', 'No'], {


Does this already have pre-existing functions?

No pre-existing functions for this case

manodnyab · 2025-11-12T18:58:18Z

packages/core/src/awsService/cloudformation/explorer/explorer.ts

+        try {
+            // Show sign-in message when not authenticated
+            if (!globals.awsContext.getCredentialProfileName()) {
+                const signInNode = new PlaceholderNode(this as any, 'Sign in to get started')


would this allow all types of sign in?

I believe this just uses the existing login workflow

kddejong requested a review from a team as a code owner November 10, 2025 01:52

kddejong force-pushed the feature/cloudformation branch from f21322d to 09b66ad Compare November 10, 2025 01:53

Add changelog entry for CloudFormation LSP integration

89434cb

satyakigh approved these changes Nov 10, 2025

View reviewed changes

laileni-aws reviewed Nov 11, 2025

View reviewed changes

Merge branch 'feature/cloudformation' into feature/cloudformation

e19e476

laileni-aws reviewed Nov 11, 2025

View reviewed changes

kddejong added 2 commits November 11, 2025 14:31

laileni-aws reviewed Nov 11, 2025

View reviewed changes

laileni-aws approved these changes Nov 11, 2025

View reviewed changes

manodnyab reviewed Nov 12, 2025

View reviewed changes


		const DocumentPreviewNotification = new NotificationType<DocumentPreviewType>('aws/document/preview')

		export class DocumentPreview {

feat(cloudformation): Merge CloudFormation LSP integration with toolkit updates #8275

Are you sure you want to change the base?

feat(cloudformation): Merge CloudFormation LSP integration with toolkit updates #8275

Conversation

kddejong commented Nov 10, 2025

Problem

Solution

Uh oh!

github-actions bot commented Nov 10, 2025

Uh oh!

laileni-aws left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laileni-aws left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants