feat(smsus): deeplink support for SMUS #8286
Merged
+646
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vpbhargav
force-pushed
the
master
branch
2 times, most recently
from
6c1e2af to
4830c06
Compare
Contributor
Author
|
Ack on lint-duplicate-code but none of it code that I added in this PR. Most are in tests as well. Can take a look but not planning to address in this PR. |
dylanraws
reviewed
Nov 12, 2025
packages/core/src/awsService/sagemaker/detached-server/routes/getSessionAsync.ts
Show resolved
Hide resolved
kzr-at-amazon
approved these changes
Nov 13, 2025
**Description** PR adds deeplink support for SageMaker Unified Studio. Details: 1. Uses a new URI handler for SMUS to have distinct path for SMUS and SM AI. This helps distinguish between the two to special case behavior and also to avoid older toolkit releases from picking up SMUS deeplinks. 2. For SMUS, we are not able to trigger the refresh flow yet. So we will show an error page and ask user to retry from portal again. 3. Added smus specific telemetry and added optional params that we will get from query params. Since we do not have creds or connection info already, all telemetry data has to come from deeplink. 4. Had to change from vscode default context to Toolkit wrapper of that context to be able to register URI. **Motivation** Support deeplink for smus, improve discoverability of feature. **Testing Done** Unit tests. Tested locally, sharing recording with team offline.
Contributor
Author
|
/retryBuilds |
dylanraws
approved these changes
Nov 13, 2025
liuzulin
reviewed
Nov 13, 2025
liuzulin
approved these changes
Nov 13, 2025
liuzulin
reviewed
Nov 13, 2025
ashishrp-aws
approved these changes
Nov 13, 2025
Will-ShaoHua
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds deeplink support for SageMaker Unified Studio.
Details:
Motivation
Support deeplink for smus, improve discoverability of feature.
Testing Done
Unit tests. Tested locally, sharing recording with team offline.
feature/xbranches will not be squash-merged at release time.