Remove support for Node 12.x (#542)

* Remove support for Node 12.x

* Remove deprecated code

Author: carolabadeer

.github/workflows/pr-build.yml

@@ -17,7 +17,6 @@ jobs:
           - ubuntu-latest
           - windows-latest
         node-version:
-          - 12.x
           - 14.x
           - 16.x
         include:

README.md

@@ -12,7 +12,7 @@ If you want additional features when tracing your Node.js applications, please [
 
 ## Installing
 
-The AWS X-Ray SDK for Node.js is compatible with Node.js version 12.x and later.
+The AWS X-Ray SDK for Node.js is compatible with Node.js version 14.x and later.
 There may be issues when running on the latest odd-numbered release of Node.js.
 
 The latest stable version of the SDK is available from NPM. For local development, install the SDK in your project directory with npm.

package.json

@@ -53,7 +53,7 @@
     "upath": "^1.2.0"
   },
   "engines": {
-    "node": ">= 12.x",
+    "node": ">= 14.x",
     "npm": ">= 2.x"
   },
   "dependencies": {

packages/core/lib/patchers/http_p.js

@@ -143,15 +143,6 @@ function enableCapture(module, downstreamXRayEnabled, subsegmentCallback) {
         subsegment.addRemoteRequestData(this, null, madeItToDownstream && downstreamXRayEnabled);
         subsegment.close(e);
       }
-
-      // Only need to remove our listener & re-emit if we're not listening using the errorMonitor,
-      // e.g. the app is running on Node 10. Otherwise the errorMonitor will re-emit automatically.
-      // See: https://github.com/aws/aws-xray-sdk-node/issues/318
-      // TODO: Remove this logic once node 12 support is deprecated
-      if (!events.errorMonitor && this.listenerCount('error') <= 1) {
-        this.removeListener('error', errorCapturer);
-        this.emit('error', e);
-      }
     };
 
     const optionsCopy = Utils.objectWithoutProperties(options, ['Segment'], true);

packages/core/package.json

@@ -16,7 +16,7 @@
   "main": "dist/lib/index.js",
   "types": "dist/lib/index.d.ts",
   "engines": {
-    "node": ">= 12.x"
+    "node": ">= 14.x"
   },
   "directories": {
     "test": "test"

packages/express/package.json

@@ -9,7 +9,7 @@
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "engines": {
-    "node": ">= 12.x"
+    "node": ">= 14.x"
   },
   "directories": {
     "test": "test"

packages/full_sdk/package.json

@@ -10,7 +10,7 @@
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "engines": {
-    "node": ">= 12.x"
+    "node": ">= 14.x"
   },
   "dependencies": {
     "aws-xray-sdk-core": "file:../core",

packages/mysql/package.json

@@ -9,7 +9,7 @@
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "engines": {
-    "node": ">= 12.x"
+    "node": ">= 14.x"
   },
   "directories": {
     "test": "test"

packages/postgres/package.json

@@ -9,7 +9,7 @@
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "engines": {
-    "node": ">= 12.x"
+    "node": ">= 14.x"
   },
   "directories": {
     "test": "test"

packages/restify/package.json

@@ -9,7 +9,7 @@
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "engines": {
-    "node": ">= 12.x"
+    "node": ">= 14.x"
   },
   "directories": {
     "test": "test"