Skip to content

Commit 283ebd5

Browse files
authored
replace macos-latest with macos-13 for node14.x tests (#649)
1 parent 58dd586 commit 283ebd5

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

.github/workflows/pr-build.yml

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,23 @@ jobs:
2626
- os: ubuntu-latest
2727
node-version: 16.x
2828
coverage: true
29-
# Issue with npm6 on windows resulting in failing workflows:
30-
# https://github.com/npm/cli/issues/4341#issuecomment-1040608101
31-
# Since node14 is EOL, we can drop this set from our tests.
32-
# We still test node14 on other platforms.
29+
- os: macos-13
30+
node-version: 14.x
3331
exclude:
32+
# Issue with npm6 on windows resulting in failing workflows:
33+
# https://github.com/npm/cli/issues/4341#issuecomment-1040608101
34+
# Since node14 is EOL, we can drop this set from our tests.
35+
# We still test node14 on other platforms.
3436
- os: windows-latest
3537
node-version: 14.x
38+
# https://github.com/actions/runner-images/issues/9741
39+
# macos-latest provides only ARM hosts
40+
# https://github.com/nodejs/node/issues/36161
41+
# https://github.com/nodejs/node/issues/40126
42+
# Without workarounds, Node.js 14 isn't supported on ARM macos
43+
# As workaround, test on macos-13 version instead
44+
- os: macos-latest
45+
node-version: 14.x
3646

3747
steps:
3848
- name: Checkout AWS XRay SDK Node Repository @ default branch latest

0 commit comments

Comments
 (0)