Merge pull request #641 from mxiamxia/fix_trace_id

TraceId timestamp supports string starts with '0'

Author: mxiamxia

packages/core/lib/segments/attributes/trace_id.js

@@ -56,6 +56,8 @@ class TraceID {
     if (timestamp === 'NaN') {
       logger.getLogger().error('Trace ID timestamp must be a hex-encoded value');
       return traceID;
+    } else {
+      timestamp = timestamp.padStart(8, '0');
     }
 
     traceID.version = version;

packages/core/test/unit/segments/attributes/trace_id.test.js

@@ -44,4 +44,12 @@ describe('TraceID', function() {
     var traceId = TraceID.FromString(traceStr);
     assert.equal(traceId.toString(), traceStr);
   });
+
+  it('should keep leading 0\'s for trace ID from given string', function() {
+    const traceStr = '1-00fbe041-2c7ad569f5d6ff149137be86';
+    var traceId = TraceID.FromString(traceStr);
+    assert.equal(traceId.version, 1);
+    assert.equal(traceId.timestamp, '00fbe041');
+    assert.equal(traceId.id, '2c7ad569f5d6ff149137be86');
+  });
 });