Skip to content

Commit 2f6a2dd

Browse files
author
Feiyang Liu
committed
patches to show both versions in about dialog
1 parent cf44d7e commit 2f6a2dd

File tree

3 files changed

+29
-0
lines changed

3 files changed

+29
-0
lines changed

patches/sagemaker.series

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,4 @@ sagemaker/sagemaker-extension-smus-support.diff
3939
sagemaker/post-startup-notifications.diff
4040
sagemaker/sagemaker-extensions-sync.diff
4141
sagemaker/fix-port-forwarding.diff
42+
sagemaker/display-both-versions-in-about.diff
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
Index: code-editorv2/code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts
2+
===================================================================
3+
--- code-editorv2.orig/code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts
4+
+++ code-editorv2/code-editor-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts
5+
@@ -79,7 +79,8 @@ export class BrowserDialogHandler extend
6+
async about(): Promise<void> {
7+
const detailString = (useAgo: boolean): string => {
8+
return localize('aboutDetail',
9+
- "Code Editor Version: {0}\nCode - OSS Version: {1}\nDate: {2}\nBrowser: {3}",
10+
+ "SageMaker Code Editor Version: {0}\nCode Editor Version: {1}\nCode - OSS Version: {2}\nDate: {3}\nBrowser: {4}",
11+
+ this.productService.sagemakerCodeEditorVersion || 'Unknown',
12+
this.productService.codeEditorVersion || 'Unknown',
13+
this.productService.version || 'Unknown',
14+
this.productService.date ? `${this.productService.date}${useAgo ? ' (' + fromNow(new Date(this.productService.date), true) + ')' : ''}` : 'Unknown',
15+
Index: code-editorv2/code-editor-src/src/vs/base/common/product.ts
16+
===================================================================
17+
--- code-editorv2.orig/code-editor-src/src/vs/base/common/product.ts
18+
+++ code-editorv2/code-editor-src/src/vs/base/common/product.ts
19+
@@ -62,6 +62,8 @@ export interface IProductConfiguration {
20+
readonly quality?: string;
21+
readonly commit?: string;
22+
readonly codeEditorVersion?: string;
23+
+ readonly sagemakerCodeEditorVersion?: string;
24+
+
25+
26+
readonly nameShort: string;
27+
readonly nameLong: string;

patches/series

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
sagemaker/display-both-versions-in-about.diff

0 commit comments

Comments
 (0)