Skip to content

Commit ba638c4

Browse files
author
Feiyang Liu
committed
update patches to fix build error
1 parent db61954 commit ba638c4

File tree

6 files changed

+39
-40
lines changed

6 files changed

+39
-40
lines changed

package-lock-overrides/sagemaker.series/package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock-overrides/web-embedded-with-terminal.series/package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock-overrides/web-embedded.series/package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock-overrides/web-server.series/package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

patches/sagemaker/post-startup-notifications.diff

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -659,23 +659,22 @@ Index: code-editor-src/extensions/post-startup-notifications/tsconfig.json
659659
===================================================================
660660
--- /dev/null
661661
+++ code-editor-src/extensions/post-startup-notifications/tsconfig.json
662-
@@ -0,0 +1,17 @@
662+
@@ -0,0 +1,14 @@
663663
+{
664-
+ "compilerOptions": {
665-
+ "module": "Node16",
666-
+ "target": "ES2022",
667-
+ "lib": [
668-
+ "ES2022"
669-
+ ],
670-
+ "sourceMap": true,
671-
+ "rootDir": "src",
672-
+ "strict": true, /* enable all strict type-checking options */
673-
+ "isolatedModules": true
674-
+ /* Additional Checks */
675-
+ // "noImplicitReturns": true, /* Report error when not all code paths in function return a value. */
676-
+ // "noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
677-
+ // "noUnusedParameters": true, /* Report errors on unused parameters. */
678-
+ }
664+
+ "extends": "../tsconfig.base.json",
665+
+ "compilerOptions": {
666+
+ "outDir": "./out",
667+
+ "types": [
668+
+ "node"
669+
+ ],
670+
+ "typeRoots": [
671+
+ "./node_modules/@types"
672+
+ ]
673+
+ },
674+
+ "include": [
675+
+ "src/**/*",
676+
+ "../../src/vscode-dts/vscode.d.ts"
677+
+ ]
679678
+}
680679
\ No newline at end of file
681680
Index: code-editor-src/extensions/post-startup-notifications/webpack.config.js

patches/web-embedded/revise-help-about-modal-content-and-buttons.diff

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Index: third-party-src/src/vs/workbench/browser/parts/dialogs/dialog.web.contrib
1515
} else {
1616
const aboutDialogDetails = createBrowserAboutDialogDetails(this.productService);
1717
- await this.impl.value.about(aboutDialogDetails.title, aboutDialogDetails.details, aboutDialogDetails.detailsToCopy);
18-
+ await this.impl.value.about(aboutDialogDetails.title, aboutDialogDetails.details);
18+
+ await this.impl.value.about(aboutDialogDetails.title, aboutDialogDetails.details, aboutDialogDetails.details);
1919
}
2020
} catch (error) {
2121
result = error;
@@ -28,7 +28,7 @@ Index: third-party-src/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts
2828
}
2929

3030
- async about(title: string, details: string, detailsToCopy: string): Promise<void> {
31-
+ async about(title: string, details: string): Promise<void> {
31+
+ async about(title: string, details: string, _detailsToCopy: string): Promise<void> {
3232

3333
- const { button } = await this.doShow(
3434
+ await this.doShow(
@@ -61,7 +61,7 @@ Index: third-party-src/src/vs/platform/dialogs/browser/dialog.ts
6161
import { localize } from '../../../nls.js';
6262
import { IKeybindingService } from '../../keybinding/common/keybinding.js';
6363
import { ResultKind } from '../../keybinding/common/keybindingResolver.js';
64-
@@ -43,24 +42,13 @@ export function createWorkbenchDialogOpt
64+
@@ -43,24 +42,14 @@ export function createWorkbenchDialogOpt
6565
};
6666
}
6767

@@ -90,4 +90,4 @@ Index: third-party-src/src/vs/platform/dialogs/browser/dialog.ts
9090
+ details: details
9191
};
9292
}
93-
-
93+

0 commit comments

Comments
 (0)