Skip to content

Commit 0462d28

Browse files
committed
fix if
Signed-off-by: sirutBuasai <sirutbuasai27@outlook.com>
1 parent a2411e2 commit 0462d28

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

.github/workflows/pr-sglang.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,21 +120,23 @@ jobs:
120120
- name: Set test environment
121121
id: set-env
122122
run: |
123-
124123
if [[ "${{ needs.build-sglang-image.result }}" == "success" ]]; then
125124
AWS_ACCOUNT_ID=${{ vars.AWS_ACCOUNT_ID }}
126125
IMAGE_URI=${{ needs.build-sglang-image.outputs.ci-image }}
127126
else
128127
AWS_ACCOUNT_ID=${{ vars.PROD_AWS_ACCOUNT_ID }}
129128
IMAGE_URI=${{ vars.PROD_AWS_ACCOUNT_ID }}.dkr.ecr.${{ vars.AWS_REGION }}.amazonaws.com/${{ env.PROD_SAGEMAKER_IMAGE }}
130129
fi
130+
131131
echo AWS_ACCOUNT_ID=${AWS_ACCOUNT_ID} >> ${GITHUB_OUTPUT}
132132
echo IMAGE_URI=${IMAGE_URI} >> ${GITHUB_OUTPUT}
133133
echo SGLANG_VERSION=${SGLANG_VERSION} >> ${GITHUB_OUTPUT}
134134
135135
sglang-local-benchmark-test:
136136
needs: [set-test-environment]
137-
if: needs.set-test-environment.result == 'success'
137+
if: |
138+
always() && !failure() && !cancelled() &&
139+
needs.set-test-environment.result == 'success'
138140
runs-on:
139141
- codebuild-runner-${{ github.run_id }}-${{ github.run_attempt }}
140142
fleet:x86-g6xl-runner
@@ -197,7 +199,9 @@ jobs:
197199

198200
sglang-lang-test:
199201
needs: [set-test-environment]
200-
if: needs.set-test-environment.result == 'success'
202+
if: |
203+
always() && !failure() && !cancelled() &&
204+
needs.set-test-environment.result == 'success'
201205
runs-on:
202206
- codebuild-runner-${{ github.run_id }}-${{ github.run_attempt }}
203207
fleet:x86-g6exl-runner
@@ -258,7 +262,9 @@ jobs:
258262

259263
sglang-sagemaker-endpoint-test:
260264
needs: [set-test-environment]
261-
if: needs.set-test-environment.result == 'success'
265+
if: |
266+
always() && !failure() && !cancelled() &&
267+
needs.set-test-environment.result == 'success'
262268
runs-on:
263269
- codebuild-runner-${{ github.run_id }}-${{ github.run_attempt }}
264270
fleet:default-runner

0 commit comments

Comments
 (0)