Skip to content

Commit 39bef4d

Browse files
committed
remove pr gate
Signed-off-by: sirutBuasai <sirutbuasai27@outlook.com>
1 parent 056245f commit 39bef4d

File tree

3 files changed

+59
-49
lines changed

3 files changed

+59
-49
lines changed

.github/workflows/pr-gate.yml

Lines changed: 0 additions & 40 deletions
This file was deleted.

.github/workflows/pr-sglang.yml

Lines changed: 28 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,15 @@
11
name: PR - SGLang
22

33
on:
4-
workflow_call:
4+
pull_request:
5+
branches: [main]
6+
types: [opened, reopened, synchronize]
7+
paths:
8+
- "**sglang**"
9+
10+
permissions:
11+
contents: read
12+
pull-requests: read
513

614
env:
715
# CI Image configuration
@@ -16,10 +24,27 @@ env:
1624
TEST_ARTIFACTS_DIRECTORY: "/test_artifacts/sglang"
1725

1826
jobs:
27+
gatekeeper:
28+
runs-on: ubuntu-latest
29+
concurrency:
30+
group: ${{ github.workflow }}-gate-${{ github.event.pull_request.number }}
31+
cancel-in-progress: true
32+
steps:
33+
- name: Checkout base branch (safe)
34+
uses: actions/checkout@v5
35+
with:
36+
ref: ${{ github.event.pull_request.base.sha }}
37+
fetch-depth: 1
38+
39+
- name: Run permission gate (from base)
40+
uses: ./.github/actions/pr-permission-gate
41+
1942
check-changes:
43+
needs: [gatekeeper]
44+
if: success()
2045
runs-on: ubuntu-latest
2146
concurrency:
22-
group: ${{ github.workflow }}-sglang-check-changes-${{ github.event.pull_request.number }}
47+
group: ${{ github.workflow }}-check-changes-${{ github.event.pull_request.number }}
2348
cancel-in-progress: true
2449
outputs:
2550
build-change: ${{ steps.changes.outputs.build-change }}
@@ -109,7 +134,7 @@ jobs:
109134
(needs.check-changes.outputs.build-change == 'true' || needs.check-changes.outputs.test-change == 'true')
110135
runs-on: ubuntu-latest
111136
concurrency:
112-
group: ${{ github.workflow }}-set-sglang-test-environment-${{ github.event.pull_request.number }}
137+
group: ${{ github.workflow }}-set-test-environment-${{ github.event.pull_request.number }}
113138
cancel-in-progress: true
114139
outputs:
115140
aws-account-id: ${{ steps.set-env.outputs.AWS_ACCOUNT_ID }}

.github/workflows/pr-vllm.yml

Lines changed: 31 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,15 @@
11
name: PR - vLLM
22

33
on:
4-
workflow_call:
4+
pull_request:
5+
branches: [main]
6+
types: [opened, reopened, synchronize]
7+
paths:
8+
- "**vllm**"
9+
10+
permissions:
11+
contents: read
12+
pull-requests: read
513

614
env:
715
# CI Image configuration
@@ -18,10 +26,27 @@ env:
1826
FORCE_COLOR: "1"
1927

2028
jobs:
29+
gatekeeper:
30+
runs-on: ubuntu-latest
31+
concurrency:
32+
group: ${{ github.workflow }}-gate-${{ github.event.pull_request.number }}
33+
cancel-in-progress: true
34+
steps:
35+
- name: Checkout base branch (safe)
36+
uses: actions/checkout@v5
37+
with:
38+
ref: ${{ github.event.pull_request.base.sha }}
39+
fetch-depth: 1
40+
41+
- name: Run permission gate (from base)
42+
uses: ./.github/actions/pr-permission-gate
43+
2144
check-changes:
45+
needs: [gatekeeper]
46+
if: success()
2247
runs-on: ubuntu-latest
2348
concurrency:
24-
group: ${{ github.workflow }}-vllm-check-changes-${{ github.event.pull_request.number }}
49+
group: ${{ github.workflow }}-check-changes-${{ github.event.pull_request.number }}
2550
cancel-in-progress: true
2651
outputs:
2752
build-change: ${{ steps.changes.outputs.build-change }}
@@ -50,10 +75,10 @@ jobs:
5075
- "scripts/vllm/**"
5176
- "scripts/common/**"
5277
- "scripts/telemetry/**"
78+
- ".github/workflows/pr-vllm*"
5379
test-change:
5480
- "test/vllm/**"
5581
56-
# - ".github/workflows/pr-vllm*"
5782
# ==============================================
5883
# =============== vLLM EC2 jobs ================
5984
# ==============================================
@@ -111,7 +136,7 @@ jobs:
111136
(needs.check-changes.outputs.build-change == 'true' || needs.check-changes.outputs.test-change == 'true')
112137
runs-on: ubuntu-latest
113138
concurrency:
114-
group: ${{ github.workflow }}-set-vllm-ec2-test-environment-${{ github.event.pull_request.number }}
139+
group: ${{ github.workflow }}-set-ec2-test-environment-${{ github.event.pull_request.number }}
115140
cancel-in-progress: true
116141
outputs:
117142
aws-account-id: ${{ steps.set-env.outputs.AWS_ACCOUNT_ID }}
@@ -395,7 +420,7 @@ jobs:
395420
(needs.check-changes.outputs.build-change == 'true' || needs.check-changes.outputs.test-change == 'true')
396421
runs-on: ubuntu-latest
397422
concurrency:
398-
group: ${{ github.workflow }}-set-vllm-rayserve-test-environment-${{ github.event.pull_request.number }}
423+
group: ${{ github.workflow }}-set-rayserve-test-environment-${{ github.event.pull_request.number }}
399424
cancel-in-progress: true
400425
outputs:
401426
aws-account-id: ${{ steps.set-env.outputs.AWS_ACCOUNT_ID }}
@@ -679,7 +704,7 @@ jobs:
679704
(needs.check-changes.outputs.build-change == 'true' || needs.check-changes.outputs.test-change == 'true')
680705
runs-on: ubuntu-latest
681706
concurrency:
682-
group: ${{ github.workflow }}-set-vllm-sagemaker-test-environment-${{ github.event.pull_request.number }}
707+
group: ${{ github.workflow }}-set-sagemaker-test-environment-${{ github.event.pull_request.number }}
683708
cancel-in-progress: true
684709
outputs:
685710
aws-account-id: ${{ steps.set-env.outputs.AWS_ACCOUNT_ID }}

0 commit comments

Comments
 (0)