Skip to content

Commit 6ece509

Browse files
authored
add extra python packages to SGLang (#5474)
* install extra sgl common packages * test * fix sglang tests * revert toml
1 parent 3622cc2 commit 6ece509

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

sglang/x86_64/gpu/Dockerfile

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,16 @@ RUN dpkg -l | grep -E "cuda|nvidia|libnv" | awk '{print $2}' | xargs apt-mark ho
9595
&& apt-get clean
9696

9797
RUN pip install --no-cache-dir -U \
98-
boto3
98+
pandas \
99+
plotly \
100+
scikit-learn \
101+
numpy \
102+
pyyaml \
103+
numpy \
104+
scipy \
105+
boto3 \
106+
awscli \
107+
sagemaker
99108

100109
RUN rm -rf /tmp/*
101110

test/testrunner.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,15 @@ def main():
293293
f"NOTE: {specific_test_type} tests not supported on vllm images. Skipping..."
294294
)
295295
return
296+
elif all("sglang" in image_uri for image_uri in all_image_list) and test_type not in {
297+
"functionality_sanity",
298+
"security_sanity",
299+
"sagemaker",
300+
}:
301+
LOGGER.info(
302+
f"NOTE: {specific_test_type} tests not supported on sglang images. Skipping..."
303+
)
304+
return
296305
# quick_checks tests don't have images in it. Using a placeholder here for jobs like that
297306
try:
298307
framework, version = get_framework_and_version_from_tag(all_image_list[0])
@@ -391,10 +400,6 @@ def main():
391400
run_vllm_tests(f"{specific_test_type}", all_image_list, new_test_structure_enabled)
392401
return
393402

394-
# if framework == "sglang":
395-
# run_new_tests()
396-
# return
397-
398403
eks_cluster_name = f"dlc-{framework}-{build_context}"
399404
eks_utils.eks_setup()
400405
if eks_utils.is_eks_cluster_active(eks_cluster_name):
@@ -498,10 +503,6 @@ def main():
498503
run_vllm_tests("sagemaker", all_image_list, new_test_structure_enabled)
499504
return
500505

501-
# if "sglang" in dlc_images:
502-
# run_new_tests()
503-
# return
504-
505506
if "habana" in dlc_images:
506507
LOGGER.info(f"Skipping SM tests for Habana. Images: {dlc_images}")
507508
# Creating an empty file for because codebuild job fails without it
@@ -557,7 +558,7 @@ def main():
557558
"neuron": "Skipping - there are no local mode tests for Neuron",
558559
"huggingface-tensorflow-training": "Skipping - there are no local mode tests for HF TF training",
559560
"vllm": "Skipping - there are no local mode tests for VLLM",
560-
"sglang": "Skipping - there are no local mode tests for sgland",
561+
"sglang": "Skipping - there are no local mode tests for sglang",
561562
}
562563

563564
for skip_condition, reason in sm_local_to_skip.items():

0 commit comments

Comments
 (0)