move aws_session to global conftest

Signed-off-by: sirutBuasai <sirutbuasai27@outlook.com>

Author: sirutBuasai

.github/workflows/pr-sglang.yml

@@ -14,6 +14,9 @@ concurrency:
   group: pr-sglang-${{ github.event.pull_request.number }}
   cancel-in-progress: true
 
+env:
+  FORCE_COLOR: "1"
+
 jobs:
   check-changes:
     runs-on: ubuntu-latest

.pre-commit-config.yaml

@@ -1,7 +1,6 @@
 default_install_hook_types:
   - commit-msg
   - pre-commit
-  - pre-push
 
 default_stages:
   - pre-commit
@@ -75,7 +74,7 @@ repos:
         name: "🐍 python · Format python"
       - id: ruff-check
         name: "🐍 python · Lint python"
-        stages: [pre-push]
+        args: ["--fix"]
       - id: ruff-check
         name: "🐍 python · Sort python imports"
         args: ["check", "--select", "I", "--fix"]

test/conftest.py

@@ -13,12 +13,27 @@
 """Common pytest fixtures for all tests under module test/"""
 
 import pytest
+from test_utils.aws import AWSSessionManager
+from test_utils.constants import DEFAULT_REGION
 
 
 def pytest_addoption(parser):
     parser.addoption("--image-uri", action="store", help="Image URI to be tested")
+    parser.addoption(
+        "--region", action="store", default=DEFAULT_REGION, help="AWS Region to test image on AWS"
+    )
 
 
 @pytest.fixture(scope="session")
 def image_uri(request):
     return request.config.getoption("--image-uri")
+
+
+@pytest.fixture(scope="session")
+def region(request):
+    return request.config.getoption("--region")
+
+
+@pytest.fixture(scope="session")
+def aws_session(region):
+    return AWSSessionManager(region)

test/sglang/sagemaker/test_sm_endpoint.py

@@ -22,7 +22,6 @@
 from sagemaker.model import Model
 from sagemaker.predictor import Predictor
 from test_utils import clean_string, random_suffix_name, wait_for_status
-from test_utils.aws import AWSSessionManager
 
 # To enable debugging, change logging.INFO to logging.DEBUG
 LOGGER = logging.getLogger(__name__)
@@ -50,16 +49,12 @@ def get_hf_token(aws_session):
         LOGGER.error(f"Failed to retrieve HuggingFace token: {e}")
         raise e
 
+    # Do not print secrets token in logs
     response = json.loads(get_secret_value_response["SecretString"])
     token = response.get("HF_TOKEN")
     return token
 
 
-@pytest.fixture(scope="module")
-def aws_session():
-    return AWSSessionManager()
-
-
 @pytest.fixture(scope="function")
 def model_id(request):
     # Return the model_id given by the test parameter