You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In superchain, we are long gone from `1.18`, [and are now at 1.23](https://github.com/aws/jsii-superchain/blob/main/superchain/Dockerfile#L87). Superchain is what we use to release jsii in our release pipelines, so this creates an inconsistency between the pre-merge and post-merge environments.
I guess until now we haven't seen this cause an issue, but now, with go `1.23`, our release pipelines are failing with:
```console
@jsii/go-runtime:
--
@jsii/go-runtime: ·[1G@jsii/go-runtime: $ cd jsii-runtime-go && go test ./...
@jsii/go-runtime: go: downloading github.com/Masterminds/semver/v3 v3.3.1
@jsii/go-runtime: go: downloading github.com/stretchr/testify v1.10.0
@jsii/go-runtime: go: downloading github.com/davecgh/go-spew v1.1.1
@jsii/go-runtime: go: downloading github.com/pmezard/go-difflib v1.0.0
@jsii/go-runtime: go: downloading gopkg.in/yaml.v3 v3.0.1
@jsii/go-runtime: go: updates to go.mod needed; to update it:
@jsii/go-runtime: go mod tidy
@jsii/go-runtime:
@jsii/go-runtime: ·[1G@jsii/go-runtime: error Command failed with exit code 1.
@jsii/go-runtime: ·[1G
@jsii/go-runtime: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
Seems like this new version requires an additional statement in the check-sum file.
```console
--- a/packages/@jsii/go-runtime/jsii-runtime-go/go.sum
+++ b/packages/@jsii/go-runtime/jsii-runtime-go/go.sum
@@ -5,6 +5,7 @@ github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSs
github.com/fatih/color v1.18.0 h1:S8gINlzdQ840/4pfAwic/ZE0djQEH3wM94VfqLTZcOM=
github.com/fatih/color v1.18.0/go.mod h1:4FelSpRwEGDpQ12mAdzqdOukCy4u8WUtOY6lkT/6HfU=
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
+github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/mattn/go-colorable v0.1.13 h1:fFA4WZxdEF4tXPZVKMLwD8oUnCTTo08duU7wxecdEvA=
github.com/mattn/go-colorable v0.1.13/go.mod h1:7S9/ev0klgBDR4GtXTXX8a3vIGJpMovkB8vQcUbaXHg=
github.com/mattn/go-isatty v0.0.16/go.mod h1:kYGgaQfpe5nmfYZH+SKPsOc2e4SrIfOl2e/yFXSvRLM=
```
We should device a mechanism to align superchain versions with the github workflow versions.
### For now, we make the following change:
- Change baseline version to use 1.23 - which is the version we use in our release pipeline.
- Change alternate go version test to use 1.24 (the latest as of writing).
- Change pacmak integration tests go vesion to use 1.23, same as baseline (not sure why it used a different one earlier).
---
By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].
[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
t.Errorf("expected an error, but no error received")
144
-
} elseif!strings.Contains(err.Error(), "no such file or directory") &&!strings.Contains(err.Error(), "file does not exist") {
145
-
// We have 2 options here because Windows returns a different error message, of course...
146
-
t.Errorf("expected 'no such file or directory' or 'file does not exist', got %v", err.Error())
144
+
} elseif!strings.Contains(err.Error(), "no such file or directory") &&!strings.Contains(err.Error(), "file does not exist") &&!strings.Contains(err.Error(), "file not found") {
145
+
// We have 3 options here because Windows returns a different error message, of course...
146
+
t.Errorf("expected 'no such file or directory' or 'file does not exist' or 'file not found', got %v", err.Error())
0 commit comments