chore: more linting fixes

Author: anasstahr

.eslintrc.js

@@ -28,7 +28,7 @@ module.exports = {
         '@typescript-eslint/no-non-null-assertion': 'error',
         '@typescript-eslint/no-unsafe-assignment': 'off',
         '@typescript-eslint/no-unsafe-member-access': 'off',
-        '@typescript-eslint/no-redundant-type-constituents': 'error',
+        '@typescript-eslint/no-redundant-type-constituents': 'warn',
         '@typescript-eslint/unbound-method': 'error',
         '@typescript-eslint/no-misused-promises': 'warn',
         '@typescript-eslint/no-unsafe-return': 'off',

runtimes/runtimes/chat/baseChat.ts

@@ -144,21 +144,15 @@ export class BaseChat implements Chat {
     }
 
     public sendChatUpdate(params: ChatUpdateParams) {
-        this.connection
-            .sendNotification(chatUpdateNotificationType.method, params)
-            .then(() => {})
-            .catch(() => {})
+        return this.connection.sendNotification(chatUpdateNotificationType.method, params)
     }
 
     public onFileClicked(handler: NotificationHandler<FileClickParams>) {
         this.connection.onNotification(fileClickNotificationType.method, handler)
     }
 
     public sendContextCommands(params: ContextCommandParams) {
-        this.connection
-            .sendNotification(contextCommandsNotificationType.method, params)
-            .then(() => {})
-            .catch(() => {})
+        return this.connection.sendNotification(contextCommandsNotificationType.method, params)
     }
 
     public onCreatePrompt(handler: NotificationHandler<CreatePromptParams>) {

runtimes/runtimes/lsp/router/lspRouter.ts

@@ -170,7 +170,11 @@ ${JSON.stringify({ ...result.capabilities, ...result.awsServerCapabilities })}`
             this.lspConnection.client
                 .register(DidChangeConfigurationNotification.type, undefined)
                 .then(() => {})
-                .catch(() => {})
+                .catch(e => {
+                    this.lspConnection.console.error(
+                        `Failed to register DidChangeConfigurationNotification: ${e.message}`
+                    )
+                })
         }
 
         this.routeNotificationToAllServers((server, params) => server.sendInitializedNotification(params), params)

types/chat.ts

@@ -188,7 +188,7 @@ export interface QuickActionCommand {
 }
 
 export type ContextCommandIconType = 'file' | 'folder' | 'code-block' | 'list-add' | 'magic'
-export type IconType = 'ContextCommandIconType' | 'help' | 'trash' | 'search' | 'calendar'
+export type IconType = ContextCommandIconType | 'help' | 'trash' | 'search' | 'calendar' | string
 
 /**
  * Configuration object for registering chat quick actions groups.