feat: add LSP extension for sending telemetry for inline chat result action (#408)

* feat: add LSP extension for sending telemetry for inline chat result action

* fix: correct formatting

* feat: update the naming from logInlineChatResult to inlineChatResult

* fix: full variable names, removed timestamp and added doc string for notification type

* fix: refactored tha InlineChatResultParams field names

---------

Co-authored-by: Paras <pmiparas@amazon.com>

Author: pras0131

runtimes/protocol/chat.ts

@@ -46,6 +46,8 @@ import {
     ContextCommandParams,
     CREATE_PROMPT_NOTIFICATION_METHOD,
     CreatePromptParams,
+    INLINE_CHAT_RESULT_NOTIFICATION_METHOD,
+    InlineChatResultParams,
     ListConversationsParams,
     ListConversationsResult,
     LIST_CONVERSATIONS_REQUEST_METHOD,
@@ -130,6 +132,13 @@ export const contextCommandsNotificationType = new ProtocolNotificationType<Cont
 export const createPromptNotificationType = new ProtocolNotificationType<CreatePromptParams, void>(
     CREATE_PROMPT_NOTIFICATION_METHOD
 )
+/**
+ * The inline chat result notification is sent from client to server to notify the action taken by the user
+ * from the suggested response returned by the server.
+ */
+export const inlineChatResultNotificationType = new ProtocolNotificationType<InlineChatResultParams, void>(
+    INLINE_CHAT_RESULT_NOTIFICATION_METHOD
+)
 
 // history
 export const listConversationsRequestType = new AutoParameterStructuresProtocolRequestType<

runtimes/runtimes/base-runtime.ts

@@ -41,6 +41,7 @@ import {
     inlineChatRequestType,
     contextCommandsNotificationType,
     createPromptNotificationType,
+    inlineChatResultNotificationType,
     listConversationsRequestType,
     conversationClickRequestType,
     GetSerializedChatParams,
@@ -167,6 +168,7 @@ export const baseRuntime = (connections: { reader: MessageReader; writer: Messag
         onFileClicked: handler => lspConnection.onNotification(fileClickNotificationType.method, handler),
         sendContextCommands: params => lspConnection.sendNotification(contextCommandsNotificationType.method, params),
         onCreatePrompt: handler => lspConnection.onNotification(createPromptNotificationType.method, handler),
+        onInlineChatResult: handler => lspConnection.onNotification(inlineChatResultNotificationType.method, handler),
         onListConversations: handler => lspConnection.onRequest(listConversationsRequestType.method, handler),
         onConversationClick: handler => lspConnection.onRequest(conversationClickRequestType.method, handler),
         getSerializedChat: params => lspConnection.sendRequest(getSerializedChatRequestType.method, params),

runtimes/runtimes/chat/baseChat.ts

@@ -43,6 +43,8 @@ import {
     contextCommandsNotificationType,
     CreatePromptParams,
     createPromptNotificationType,
+    InlineChatResultParams,
+    inlineChatResultNotificationType,
     listConversationsRequestType,
     ListConversationsParams,
     ListConversationsResult,
@@ -145,6 +147,10 @@ export class BaseChat implements Chat {
         this.connection.onNotification(createPromptNotificationType.method, handler)
     }
 
+    public onInlineChatResult(handler: NotificationHandler<InlineChatResultParams>) {
+        this.connection.onNotification(inlineChatResultNotificationType.method, handler)
+    }
+
     public onListConversations(handler: RequestHandler<ListConversationsParams, ListConversationsResult, void>) {
         this.connection.onRequest(listConversationsRequestType.method, handler)
     }

runtimes/server-interface/chat.ts

@@ -24,6 +24,7 @@ import {
     InlineChatResult,
     ContextCommandParams,
     CreatePromptParams,
+    InlineChatResultParams,
     ListConversationsParams,
     ListConversationsResult,
     ConversationClickParams,
@@ -67,4 +68,5 @@ export type Chat = {
     chatOptionsUpdate: (params: ChatOptionsUpdateParams) => void
     sendContextCommands: (params: ContextCommandParams) => void
     onCreatePrompt: (handler: NotificationHandler<CreatePromptParams>) => void
+    onInlineChatResult: (handler: NotificationHandler<InlineChatResultParams>) => void
 }

types/chat.ts

@@ -22,6 +22,7 @@ export const CHAT_OPTIONS_UPDATE_NOTIFICATION_METHOD = 'aws/chat/chatOptionsUpda
 // context
 export const CONTEXT_COMMAND_NOTIFICATION_METHOD = 'aws/chat/sendContextCommands'
 export const CREATE_PROMPT_NOTIFICATION_METHOD = 'aws/chat/createPrompt'
+export const INLINE_CHAT_RESULT_NOTIFICATION_METHOD = 'aws/chat/inlineChatResult'
 // history
 export const LIST_CONVERSATIONS_REQUEST_METHOD = 'aws/chat/listConversations'
 export const CONVERSATION_CLICK_REQUEST_METHOD = 'aws/chat/conversationClick'
@@ -327,8 +328,28 @@ export interface CreatePromptParams {
     promptName: string
 }
 
-// history
+export interface ProgrammingLanguage {
+    languageName: string
+}
+
+export type InlineChatUserDecision = 'ACCEPT' | 'REJECT' | 'DISMISS' | string
 
+export interface InlineChatResultParams {
+    requestId: string
+    inputLength?: number
+    selectedLines?: number
+    suggestionAddedChars?: number
+    suggestionAddedLines?: number
+    suggestionDeletedChars?: number
+    suggestionDeletedLines?: number
+    codeIntent?: boolean
+    userDecision?: InlineChatUserDecision
+    responseStartLatency?: number
+    responseEndLatency?: number
+    programmingLanguage?: ProgrammingLanguage
+}
+
+// history
 export type TextBasedFilterOption = {
     type: 'textarea' | 'textinput'
     placeholder?: string