chore: fix linting errors

Author: anasstahr

chat-client-ui-types/src/uiContracts.ts

@@ -150,5 +150,5 @@ export type UiMessageResultParams =
       }
 export interface ErrorResult {
     message: string
-    type: 'InvalidRequest' | 'InternalError' | 'UnknownError' | string
+    type: 'InvalidRequest' | 'InternalError' | 'UnknownError'
 }

runtimes/package.json

@@ -60,6 +60,7 @@
         "@types/mock-fs": "^4.13.4",
         "@types/node": "^22.13.1",
         "@types/node-forge": "^1.3.11",
+        "@types/win-ca": "^3.5.4",
         "assert": "^2.0.0",
         "copyfiles": "^2.4.1",
         "husky": "^9.1.7",

runtimes/protocol/notification.ts

@@ -13,16 +13,16 @@ export interface NotificationContent {
     readonly title?: string
 }
 
-export namespace FollowupNotificationActionType {
-    export const Acknowledge = 'Acknowledge'
-}
+export const FollowupNotificationActionType = {
+    Acknowledge: 'Acknowledge',
+} as const
 
 export type FollowupNotificationActionType = typeof FollowupNotificationActionType.Acknowledge
 
-export namespace NotificationActionType {
-    export const Url = 'Url'
-    export const Marketplace = 'Marketplace'
-}
+const NotificationActionType = {
+    Url: 'Url',
+    Marketplace: 'Marketplace',
+} as const
 
 export type NotificationActionType =
     | typeof NotificationActionType.Url

runtimes/runtimes/auth/auth.test.ts

@@ -396,7 +396,7 @@ describe('Auth', () => {
     describe('Encrypted credentials', () => {
         it('Rejects when encrypted flag is set wrong', async () => {
             const updateIamRequest: UpdateCredentialsParams = {
-                data: iamCredentials as IamCredentials,
+                data: iamCredentials,
                 encrypted: true,
             }
             const auth = new Auth(serverLspConnectionMock, lspRouter)
@@ -472,8 +472,8 @@ describe('Auth', () => {
 
             const jwt = await new jose.EncryptJWT(payload)
                 .setProtectedHeader({ alg: 'dir', enc: 'A256GCM' })
-                .setNotBefore(new Date().getTime() / 1000 + 50) //allows up to 60s clockTolerance
-                .setExpirationTime(new Date().getTime() / 1000 - 70) //not allowed
+                .setNotBefore(Date.now() / 1000 + 50) // allows up to 60s clockTolerance
+                .setExpirationTime(Date.now() / 1000 - 70) // not allowed
                 .encrypt(encryptionKey)
 
             const updateBearerRequest: UpdateCredentialsParams = {

runtimes/runtimes/auth/auth.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/restrict-template-expressions */
 import { jwtDecrypt } from 'jose'
 import { Connection } from 'vscode-languageserver'
 import { CredentialsEncoding } from './standalone/encryption'
@@ -97,7 +98,7 @@ export class Auth {
         return creds && (isIamCredentials(creds) || isBearerCredentials(creds))
     }
 
-    private async registerLspCredentialsUpdateHandlers() {
+    private registerLspCredentialsUpdateHandlers() {
         this.registerIamCredentialsUpdateHandlers()
         this.registerBearerCredentialsUpdateHandlers()
     }
@@ -166,11 +167,11 @@ export class Auth {
     private setCredentials(creds: Credentials) {
         if (this.areValidCredentials(creds)) {
             if (isIamCredentials(creds)) {
-                this.iamCredentials = creds as IamCredentials
+                this.iamCredentials = creds
                 // Prevent modifying credentials by implementors
                 Object.freeze(this.iamCredentials)
             } else {
-                this.bearerCredentials = creds as BearerCredentials
+                this.bearerCredentials = creds
                 Object.freeze(this.bearerCredentials)
             }
         }

runtimes/runtimes/auth/standalone/encryption.ts

@@ -2,7 +2,7 @@ import { Readable } from 'stream'
 import { CompactEncrypt } from 'jose'
 
 export function shouldWaitForEncryptionKey(): boolean {
-    return process.argv.some(arg => arg === '--set-credentials-encryption-key')
+    return process.argv.includes('--set-credentials-encryption-key')
 }
 
 export type CredentialsEncoding = 'JWT'
@@ -38,7 +38,7 @@ export function validateEncryptionDetails(encryptionDetails: EncryptionInitializ
     }
 
     if (encryptionDetails.mode !== 'JWT') {
-        throw new Error(`Unsupported encoding mode: ${encryptionDetails.mode}`)
+        throw new Error(`Unsupported encoding mode: ${String(encryptionDetails.mode)}`)
     }
 }
 
@@ -65,9 +65,9 @@ export function readEncryptionDetails(stream: Readable): Promise<EncryptionIniti
 
         // Fires when the stream has contents that can be read
         const onStreamIsReadable = () => {
-            let byteRead
+            let byteRead: Buffer | null
             while ((byteRead = stream.read(1)) !== null) {
-                if (byteRead.toString('utf-8') == '\n') {
+                if (byteRead.toString('utf-8') === '\n') {
                     clearTimer()
                     // Stop reading this stream, we have read a line from it
                     stream.removeListener('readable', onStreamIsReadable)
@@ -90,7 +90,12 @@ export function readEncryptionDetails(stream: Readable): Promise<EncryptionIniti
 /**
  * Encrypt an object with the provided key
  */
-export function encryptObjectWithKey(request: Object, key: string, alg?: string, enc?: string): Promise<string> {
+export function encryptObjectWithKey(
+    request: NonNullable<unknown>,
+    key: string,
+    alg?: string,
+    enc?: string
+): Promise<string> {
     const payload = new TextEncoder().encode(JSON.stringify(request))
     const keyBuffer = Buffer.from(key, 'base64')
     return new CompactEncrypt(payload)
@@ -126,8 +131,8 @@ export function isMessageJWEEncrypted(message: string, algorithm: string, encodi
         if (
             protectedHeader.alg &&
             protectedHeader.enc &&
-            protectedHeader.alg == algorithm &&
-            protectedHeader.enc == encoding
+            protectedHeader.alg === algorithm &&
+            protectedHeader.enc === encoding
         ) {
             return true
         }

runtimes/runtimes/base-runtime.ts

@@ -43,11 +43,6 @@ import {
     createPromptNotificationType,
     listConversationsRequestType,
     conversationClickRequestType,
-    GetSerializedChatParams,
-    GetSerializedChatResult,
-    RequestHandler,
-    TabBarActionParams,
-    TabBarActionResult,
     getSerializedChatRequestType,
     tabBarActionRequestType,
 } from '../protocol'
@@ -118,10 +113,11 @@ export const baseRuntime = (connections: { reader: MessageReader; writer: Messag
     // Set up the workspace to use the LSP Text Documents component
     const defaultHomeDir = '/home/user'
     const workspace: Workspace = {
-        getTextDocument: async uri => documents.get(uri),
-        getAllTextDocuments: async () => documents.all(),
-        getWorkspaceFolder: _uri =>
-            lspRouter.clientInitializeParams!.workspaceFolders && lspRouter.clientInitializeParams!.workspaceFolders[0],
+        getTextDocument: uri => Promise.resolve(documents.get(uri)),
+        getAllTextDocuments: () => Promise.resolve(documents.all()),
+        getWorkspaceFolder: _ =>
+            lspRouter.clientInitializeParams?.workspaceFolders &&
+            lspRouter.clientInitializeParams.workspaceFolders?.[0],
         fs: {
             copyFile: (_src, _dest, _options?) => Promise.resolve(),
             exists: _path => Promise.resolve(false),
@@ -161,9 +157,10 @@ export const baseRuntime = (connections: { reader: MessageReader; writer: Messag
         onSourceLinkClick: handler => lspConnection.onNotification(sourceLinkClickNotificationType.method, handler),
         onFollowUpClicked: handler => lspConnection.onNotification(followUpClickNotificationType.method, handler),
         openTab: params => lspConnection.sendRequest(openTabRequestType.method, params),
-        sendChatUpdate: params => lspConnection.sendNotification(chatUpdateNotificationType.method, params),
+        sendChatUpdate: params => () => lspConnection.sendNotification(chatUpdateNotificationType.method, params),
         onFileClicked: handler => lspConnection.onNotification(fileClickNotificationType.method, handler),
-        sendContextCommands: params => lspConnection.sendNotification(contextCommandsNotificationType.method, params),
+        sendContextCommands: params => () =>
+            lspConnection.sendNotification(contextCommandsNotificationType.method, params),
         onCreatePrompt: handler => lspConnection.onNotification(createPromptNotificationType.method, handler),
         onListConversations: handler => lspConnection.onRequest(listConversationsRequestType.method, handler),
         onConversationClick: handler => lspConnection.onRequest(conversationClickRequestType.method, handler),
@@ -176,7 +173,7 @@ export const baseRuntime = (connections: { reader: MessageReader; writer: Messag
         onUpdateProfile: handler => lspConnection.onRequest(updateProfileRequestType, handler),
         onGetSsoToken: handler => lspConnection.onRequest(getSsoTokenRequestType, handler),
         onInvalidateSsoToken: handler => lspConnection.onRequest(invalidateSsoTokenRequestType, handler),
-        sendSsoTokenChanged: params => lspConnection.sendNotification(ssoTokenChangedRequestType, params),
+        sendSsoTokenChanged: params => () => lspConnection.sendNotification(ssoTokenChangedRequestType, params),
     }
 
     // Set up auth without encryption
@@ -188,7 +185,7 @@ export const baseRuntime = (connections: { reader: MessageReader; writer: Messag
             version: props.version,
         },
         platform: 'browser',
-        getConfiguration(key: string) {
+        getConfiguration(_key: string) {
             return undefined
         },
     }
@@ -229,8 +226,10 @@ export const baseRuntime = (connections: { reader: MessageReader; writer: Messag
                 onDidDeleteFiles: params => lspConnection.workspace.onDidDeleteFiles(params),
                 onDidRenameFiles: params => lspConnection.workspace.onDidRenameFiles(params),
                 onUpdateConfiguration: lspServer.setUpdateConfigurationHandler,
-                selectWorkspaceItem: params => lspConnection.sendRequest(selectWorkspaceItemRequestType.method, params),
-                openFileDiff: params => lspConnection.sendNotification(openFileDiffNotificationType.method, params),
+                selectWorkspaceItem: params => () =>
+                    lspConnection.sendRequest(selectWorkspaceItemRequestType.method, params),
+                openFileDiff: params => () =>
+                    lspConnection.sendNotification(openFileDiffNotificationType.method, params),
             },
             window: {
                 showMessage: params => lspConnection.sendNotification(ShowMessageNotification.method, params),
@@ -289,7 +288,9 @@ export const baseRuntime = (connections: { reader: MessageReader; writer: Messag
 
     // Free up any resources or threads used by Servers
     lspConnection.onExit(() => {
-        disposables.forEach(d => d())
+        for (const d of disposables) {
+            d()
+        }
     })
 
     // Initialize the documents listener and start the LSP connection

runtimes/runtimes/chat/baseChat.ts

@@ -124,15 +124,21 @@ export class BaseChat implements Chat {
     }
 
     public sendChatUpdate(params: ChatUpdateParams) {
-        this.connection.sendNotification(chatUpdateNotificationType.method, params)
+        this.connection
+            .sendNotification(chatUpdateNotificationType.method, params)
+            .then(() => {})
+            .catch(() => {})
     }
 
     public onFileClicked(handler: NotificationHandler<FileClickParams>) {
         this.connection.onNotification(fileClickNotificationType.method, handler)
     }
 
     public sendContextCommands(params: ContextCommandParams) {
-        this.connection.sendNotification(contextCommandsNotificationType.method, params)
+        this.connection
+            .sendNotification(contextCommandsNotificationType.method, params)
+            .then(() => {})
+            .catch(() => {})
     }
 
     public onCreatePrompt(handler: NotificationHandler<CreatePromptParams>) {

runtimes/runtimes/encoding.ts

@@ -3,8 +3,8 @@ export interface Encoding {
     encode(value: string): string
 }
 
-const HEX_PAD: string = '00'
-const HEX_REGEX: RegExp = /%([0-9A-F]{2})/g
+const HEX_PAD = '00'
+const HEX_REGEX = /%([0-9A-F]{2})/g
 export class WebBase64Encoding implements Encoding {
     constructor(private window: WindowOrWorkerGlobalScope) {}
 
@@ -22,7 +22,7 @@ export class WebBase64Encoding implements Encoding {
 
     encode(value: string): string {
         // to support Unicode chars
-        const converted = encodeURIComponent(value).replace(HEX_REGEX, (_, arg) => {
+        const converted = encodeURIComponent(value).replace(HEX_REGEX, (_, arg: string) => {
             return String.fromCharCode(parseInt(arg, 16))
         })
         return this.window.btoa(converted)

runtimes/runtimes/lsp/router/loggingServer.ts

@@ -12,15 +12,15 @@ export class LoggingServer {
         private lspConnection: Connection,
         private encoding: Encoding
     ) {
-        this.logger = new DefaultLogger(DEFAULT_LOG_LEVEL as LogLevel, this.lspConnection)
+        this.logger = new DefaultLogger(DEFAULT_LOG_LEVEL, this.lspConnection)
         this.lspServer = new LspServer(this.lspConnection, this.encoding, this.logger)
-        this.lspServer.setInitializeHandler(async (params: InitializeParams): Promise<InitializeResult> => {
+        this.lspServer.setInitializeHandler((params: InitializeParams): Promise<InitializeResult> => {
             this.updateLoggingLevel(params.initializationOptions?.logLevel ?? ('log' as LogLevel))
             return {
                 capabilities: {},
             }
         })
-        this.lspServer.setDidChangeConfigurationHandler(async params => {
+        this.lspServer.setDidChangeConfigurationHandler(async _params => {
             const logLevelConfig = await lspConnection.workspace.getConfiguration({
                 section: 'aws.logLevel',
             })