Skip to content

Commit 8b03630

Browse files
authored
fix: atx bearer no longers update credential metadata (#732)
## Problem Q relies on credential metadata for determining connection type. This is not necessary for atx-bearer since ATX only supports IDC connections. When ATX signs in, this caused the credential metadata to be overwritten and cause issues with Q if users used builderID to sign in. ## Solution When handling credential updates for ATX, we no longer updates the credential metadata so original Q auth is preserved. <!--- REMINDER: - Read CONTRIBUTING.md first. - Add test coverage for your changes. - Link to related issues/commits. - Testing: how did you test your changes? - Screenshots if applicable --> ## License By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent b217728 commit 8b03630

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

runtimes/runtimes/auth/auth.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,10 +202,9 @@ export class Auth {
202202
this.atxCredentials = bearerCredentials
203203
} else {
204204
this.connection.console.info('Runtime: Storing Q credentials in bearer')
205+
await this.handleBearerCredentialsMetadata(request.metadata)
205206
this.setCredentials(bearerCredentials)
206207
}
207-
208-
await this.handleBearerCredentialsMetadata(request.metadata)
209208
this.connection.console.info('Runtime: Successfully saved bearer credentials')
210209
} else {
211210
this.bearerCredentials = undefined

0 commit comments

Comments
 (0)