Skip to content

Commit c795f75

Browse files
authored
chore: bumping up the node version (#684)
## Problem - Node 18 is at EOL ## Solution - bumping up the node version to 24. <!--- REMINDER: - Read CONTRIBUTING.md first. - Add test coverage for your changes. - Link to related issues/commits. - Testing: how did you test your changes? - Screenshots if applicable --> ## License By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 4e13ad2 commit c795f75

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

.github/workflows/runtimes-ci.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: Set up Node
1616
uses: actions/setup-node@v4
1717
with:
18-
node-version: 20
18+
node-version: 24
1919
- name: Build
2020
run: |
2121
npm ci
@@ -33,7 +33,7 @@ jobs:
3333
- name: Set up Node
3434
uses: actions/setup-node@v4
3535
with:
36-
node-version: 20
36+
node-version: 24
3737
- name: Build
3838
run: |
3939
npm ci

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
"author": "Amazon Web Services",
2222
"license": "Apache-2.0",
2323
"engines": {
24-
"node": ">=18.0.0",
25-
"npm": ">=7.0.0 <11.0.0"
24+
"node": ">=24.0.0",
25+
"npm": ">=7.0.0 <12.0.0"
2626
},
2727
"scripts": {
2828
"clean": "ts-node ./script/clean.ts",

runtimes/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"author": "Amazon Web Services",
1111
"license": "Apache-2.0",
1212
"engines": {
13-
"node": ">=18.0.0"
13+
"node": ">=24.0.0"
1414
},
1515
"scripts": {
1616
"clean": "rm -rf out/",

runtimes/runtimes/lsp/router/initializeUtils.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import { URI } from 'vscode-uri'
22
import * as path from 'path'
33
import os from 'os'
4-
import assert = require('assert')
5-
import sinon = require('sinon')
4+
import * as assert from 'assert'
5+
import * as sinon from 'sinon'
66
import { InitializeParams, WorkspaceFolder } from 'vscode-languageserver-protocol'
77
import { getWorkspaceFoldersFromInit } from './initializeUtils'
88
import { RemoteConsole } from 'vscode-languageserver'

0 commit comments

Comments
 (0)