revert: add support for pinned context and rules (#548)" (#558)

This reverts commit 6606dcc.

Author: leigaol

runtimes/README.md

@@ -191,17 +191,11 @@ The runtime supports chat by default
 | Send chat messages and tab state update to specific tab. Depending on new vs existing`messageId` within `ChatMessage` message, the massgage will be added or updated. | `aws/chat/sendChatUpdate`          | `ChatUpdateParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Server to Client | n/a             |
 | Send file or file action click event. | `aws/chat/fileClick`          | `FileClickParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Client to Server | n/a             |
 | Send or update context commands that customer can attach to their prompt request (available via `@` in chat UI). | `aws/chat/sendContextCommands`          | `ContextCommandParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Server to Client | n/a             |
-| Send create prompt event that triggers new prompt or rule creation flow on server. | `aws/chat/createPrompt`          | `CreatePromptParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Client to Server | n/a             |
+| Send create prompt event that triggers new prompt creation flow on server. | `aws/chat/createPrompt`          | `CreatePromptParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Client to Server | n/a             |
 | Send request to list the conversations available in history: all or based on filter if provided. As there can be several filter options used, the filter in the request is a map of filter option ids to corresponding values. Possible filter options are expected to be provided in the previous `listConversations` result before filter can be used. | `aws/chat/listConversations`          | `ListConversationsParams`          | [Request](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#requestMessage) Client to Server | `ListConversationsResult`             |
 | Send conversation or conversation action click event. If no action is provided, the default action is "open". | `aws/chat/conversationClick`          | `ConversationClickParams`          | [Request](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#requestMessage) Client to Server | `ConversationClickResult`             |
 | Send request to list the MCP servers available: all or based on filter if provided. Similar to conversations, the filter in the request is a map of filter option ids to corresponding values. | `aws/chat/listMcpServers`          | `ListMcpServersParams`          | [Request](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#requestMessage) Client to Server | `ListMcpServersResult`             |
 | Send MCP server or MCP server action click event. If no action is provided, the default action is "select". | `aws/chat/mcpServerClick`          | `McpServerClickParams`          | [Request](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#requestMessage) Client to Server | `McpServerClickResult`             |
-| Send pinned context to client. Pinned context contains context commands that are pinned to the current tab. | `aws/chat/sendPinnedContext`          | `PinnedContextParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Server to Client | n/a             |
-| Notify server that pinned context has been added by the client. | `aws/chat/pinnedContextAdd`          | `PinnedContextParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Client to Server | n/a             |
-| Notify server that pinned context has been removed by the client. | `aws/chat/pinnedContextRemove`          | `PinnedContextParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Client to Server | n/a             |
-| Notify server that active editor has changed. | `aws/chat/activeEditorChanged`          | `ActiveEditorChangedParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Client to Server | n/a             |
-| Send request to list the rules available for a specific tab. | `aws/chat/listRules`          | `ListRulesParams`          | [Request](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#requestMessage) Client to Server | `ListRulesResult`             |
-| Send rule or rule folder click event. | `aws/chat/ruleClick`          | `RuleClickParams`          | [Request](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#requestMessage) Client to Server | `RuleClickResult`             |
 | Send server-initiated chat metadata updates. The interface is designed to be extensible for future chat options, currently focused on notification for developer profile changes. | `aws/chat/chatOptionsUpdate`          | `ChatOptionsUpdateParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Server to Client | n/a             |
 | Send prompt input option event changes  | `aws/chat/promptInputOptionChange`          | `PromptInputOptionChangeParams`          | [Notification](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#notificationMessage) Client to Server | n/a             |
 

runtimes/protocol/chat.ts

@@ -47,7 +47,6 @@ import {
     CREATE_PROMPT_NOTIFICATION_METHOD,
     CreatePromptParams,
     INLINE_CHAT_RESULT_NOTIFICATION_METHOD,
-    PINNED_CONTEXT_NOTIFICATION_METHOD,
     InlineChatResultParams,
     ListConversationsParams,
     ListConversationsResult,
@@ -74,17 +73,6 @@ import {
     McpServerClickParams,
     McpServerClickResult,
     MCP_SERVER_CLICK_REQUEST_METHOD,
-    ListRulesParams,
-    RuleClickParams,
-    RULE_CLICK_REQUEST_METHOD,
-    LIST_RULES_REQUEST_METHOD,
-    ListRulesResult,
-    RuleClickResult,
-    PinnedContextParams,
-    PINNED_CONTEXT_ADD_NOTIFICATION_METHOD,
-    PINNED_CONTEXT_REMOVE_NOTIFICATION_METHOD,
-    ActiveEditorChangedParams,
-    ACTIVE_EDITOR_CHANGED_NOTIFICATION_METHOD,
 } from './lsp'
 
 export const chatRequestType = new AutoParameterStructuresProtocolRequestType<
@@ -166,36 +154,6 @@ export const inlineChatResultNotificationType = new ProtocolNotificationType<Inl
     INLINE_CHAT_RESULT_NOTIFICATION_METHOD
 )
 
-// pinned context
-export const pinnedContextNotificationType = new ProtocolNotificationType<PinnedContextParams, void>(
-    PINNED_CONTEXT_NOTIFICATION_METHOD
-)
-export const onPinnedContextAddNotificationType = new ProtocolNotificationType<PinnedContextParams, void>(
-    PINNED_CONTEXT_ADD_NOTIFICATION_METHOD
-)
-export const onPinnedContextRemoveNotificationType = new ProtocolNotificationType<PinnedContextParams, void>(
-    PINNED_CONTEXT_REMOVE_NOTIFICATION_METHOD
-)
-export const activeEditorChangedNotificationType = new ProtocolNotificationType<ActiveEditorChangedParams, void>(
-    ACTIVE_EDITOR_CHANGED_NOTIFICATION_METHOD
-)
-
-// rules
-export const listRulesRequestType = new AutoParameterStructuresProtocolRequestType<
-    ListRulesParams,
-    ListRulesResult,
-    never,
-    void,
-    void
->(LIST_RULES_REQUEST_METHOD)
-
-export const ruleClickRequestType = new AutoParameterStructuresProtocolRequestType<
-    RuleClickParams,
-    RuleClickResult,
-    never,
-    void,
-    void
->(RULE_CLICK_REQUEST_METHOD)
 // history
 export const listConversationsRequestType = new AutoParameterStructuresProtocolRequestType<
     ListConversationsParams,

runtimes/runtimes/base-runtime.ts

@@ -51,12 +51,6 @@ import {
     buttonClickRequestType,
     listMcpServersRequestType,
     mcpServerClickRequestType,
-    ruleClickRequestType,
-    listRulesRequestType,
-    pinnedContextNotificationType,
-    activeEditorChangedNotificationType,
-    onPinnedContextAddNotificationType,
-    onPinnedContextRemoveNotificationType,
 } from '../protocol'
 import { createConnection } from 'vscode-languageserver/browser'
 import {
@@ -173,24 +167,16 @@ export const baseRuntime = (connections: { reader: MessageReader; writer: Messag
         sendChatUpdate: params => lspConnection.sendNotification(chatUpdateNotificationType.method, params),
         onFileClicked: handler => lspConnection.onNotification(fileClickNotificationType.method, handler),
         sendContextCommands: params => lspConnection.sendNotification(contextCommandsNotificationType.method, params),
-        sendPinnedContext: params => lspConnection.sendNotification(pinnedContextNotificationType.method, params),
-        onPinnedContextAdd: params => lspConnection.sendNotification(onPinnedContextAddNotificationType.method, params),
-        onPinnedContextRemove: params =>
-            lspConnection.sendNotification(onPinnedContextRemoveNotificationType.method, params),
-        onActiveEditorChanged: handler =>
-            lspConnection.onNotification(activeEditorChangedNotificationType.method, handler),
         onCreatePrompt: handler => lspConnection.onNotification(createPromptNotificationType.method, handler),
         onInlineChatResult: handler => lspConnection.onNotification(inlineChatResultNotificationType.method, handler),
         onListConversations: handler => lspConnection.onRequest(listConversationsRequestType.method, handler),
-        onListRules: handler => lspConnection.onRequest(listRulesRequestType.method, handler),
         onConversationClick: handler => lspConnection.onRequest(conversationClickRequestType.method, handler),
         onListMcpServers: handler => lspConnection.onRequest(listMcpServersRequestType.method, handler),
         onMcpServerClick: handler => lspConnection.onRequest(mcpServerClickRequestType.method, handler),
         getSerializedChat: params => lspConnection.sendRequest(getSerializedChatRequestType.method, params),
         onTabBarAction: handler => lspConnection.onRequest(tabBarActionRequestType.method, handler),
         onPromptInputOptionChange: handler =>
             lspConnection.onNotification(promptInputOptionChangeNotificationType.method, handler),
-        onRuleClick: handler => lspConnection.onRequest(ruleClickRequestType.method, handler),
     }
 
     const identityManagement: IdentityManagement = {

runtimes/runtimes/chat/baseChat.ts

@@ -70,18 +70,6 @@ import {
     McpServerClickParams,
     McpServerClickResult,
     mcpServerClickRequestType,
-    RuleClickParams,
-    ruleClickRequestType,
-    ListRulesParams,
-    ListRulesResult,
-    listRulesRequestType,
-    RuleClickResult,
-    PinnedContextParams,
-    pinnedContextNotificationType,
-    ActiveEditorChangedParams,
-    activeEditorChangedNotificationType,
-    onPinnedContextAddNotificationType,
-    onPinnedContextRemoveNotificationType,
 } from '../../protocol'
 import { Chat } from '../../server-interface'
 
@@ -170,22 +158,6 @@ export class BaseChat implements Chat {
         this.connection.sendNotification(contextCommandsNotificationType.method, params)
     }
 
-    public sendPinnedContext(params: PinnedContextParams) {
-        this.connection.sendNotification(pinnedContextNotificationType.method, params)
-    }
-
-    public onPinnedContextAdd(handler: NotificationHandler<PinnedContextParams>) {
-        this.connection.onNotification(onPinnedContextAddNotificationType.method, handler)
-    }
-
-    public onPinnedContextRemove(handler: NotificationHandler<PinnedContextParams>) {
-        this.connection.onNotification(onPinnedContextRemoveNotificationType.method, handler)
-    }
-
-    public onActiveEditorChanged(handler: NotificationHandler<ActiveEditorChangedParams>) {
-        this.connection.onNotification(activeEditorChangedNotificationType.method, handler)
-    }
-
     public onCreatePrompt(handler: NotificationHandler<CreatePromptParams>) {
         this.connection.onNotification(createPromptNotificationType.method, handler)
     }
@@ -198,10 +170,6 @@ export class BaseChat implements Chat {
         this.connection.onRequest(listConversationsRequestType.method, handler)
     }
 
-    public onListRules(handler: RequestHandler<ListRulesParams, ListRulesResult, void>) {
-        this.connection.onRequest(listRulesRequestType.method, handler)
-    }
-
     public onConversationClick(handler: RequestHandler<ConversationClickParams, ConversationClickResult, void>) {
         this.connection.onRequest(conversationClickRequestType.method, handler)
     }
@@ -225,8 +193,4 @@ export class BaseChat implements Chat {
     public onPromptInputOptionChange(handler: NotificationHandler<PromptInputOptionChangeParams>) {
         this.connection.onNotification(promptInputOptionChangeNotificationType.method, handler)
     }
-
-    public onRuleClick(handler: RequestHandler<RuleClickParams, RuleClickResult, void>) {
-        this.connection.onRequest(ruleClickRequestType.method, handler)
-    }
 }

runtimes/server-interface/chat.ts

@@ -41,12 +41,6 @@ import {
     ListMcpServersResult,
     McpServerClickResult,
     McpServerClickParams,
-    RuleClickParams,
-    ListRulesParams,
-    ListRulesResult,
-    RuleClickResult,
-    PinnedContextParams,
-    ActiveEditorChangedParams,
 } from '../protocol'
 
 /**
@@ -68,9 +62,6 @@ export type Chat = {
     onConversationClick: (handler: RequestHandler<ConversationClickParams, ConversationClickResult, void>) => void
     onTabBarAction: (handler: RequestHandler<TabBarActionParams, TabBarActionResult, void>) => void
     getSerializedChat: (params: GetSerializedChatParams) => Promise<GetSerializedChatResult>
-    onListRules: (handler: RequestHandler<ListRulesParams, ListRulesResult, void>) => void
-    onRuleClick: (handler: RequestHandler<RuleClickParams, RuleClickResult, void>) => void
-
     // Notifications
     onSendFeedback: (handler: NotificationHandler<FeedbackParams>) => void
     onReady: (handler: NotificationHandler<void>) => void
@@ -86,10 +77,6 @@ export type Chat = {
     onFileClicked: (handler: NotificationHandler<FileClickParams>) => void
     chatOptionsUpdate: (params: ChatOptionsUpdateParams) => void
     sendContextCommands: (params: ContextCommandParams) => void
-    sendPinnedContext: (params: PinnedContextParams) => void
-    onPinnedContextAdd: (handler: NotificationHandler<PinnedContextParams>) => void
-    onPinnedContextRemove: (handler: NotificationHandler<PinnedContextParams>) => void
-    onActiveEditorChanged: (handler: NotificationHandler<ActiveEditorChangedParams>) => void
     onCreatePrompt: (handler: NotificationHandler<CreatePromptParams>) => void
     onInlineChatResult: (handler: NotificationHandler<InlineChatResultParams>) => void
     onPromptInputOptionChange: (handler: NotificationHandler<PromptInputOptionChangeParams>) => void

types/chat.ts

@@ -26,18 +26,6 @@ export const PROMPT_INPUT_OPTION_CHANGE_METHOD = 'aws/chat/promptInputOptionChan
 export const CONTEXT_COMMAND_NOTIFICATION_METHOD = 'aws/chat/sendContextCommands'
 export const CREATE_PROMPT_NOTIFICATION_METHOD = 'aws/chat/createPrompt'
 export const INLINE_CHAT_RESULT_NOTIFICATION_METHOD = 'aws/chat/inlineChatResult'
-
-// pinned context
-export const PINNED_CONTEXT_ADD_NOTIFICATION_METHOD = 'aws/chat/pinnedContextAdd'
-export const PINNED_CONTEXT_REMOVE_NOTIFICATION_METHOD = 'aws/chat/pinnedContextRemove'
-export const RULE_CLICK_REQUEST_METHOD = 'aws/chat/ruleClick'
-
-export const PINNED_CONTEXT_NOTIFICATION_METHOD = 'aws/chat/sendPinnedContext'
-export const LIST_RULES_REQUEST_METHOD = 'aws/chat/listRules'
-
-//active tab
-export const ACTIVE_EDITOR_CHANGED_NOTIFICATION_METHOD = 'aws/chat/activeEditorChanged'
-
 // history
 export const LIST_CONVERSATIONS_REQUEST_METHOD = 'aws/chat/listConversations'
 export const CONVERSATION_CLICK_REQUEST_METHOD = 'aws/chat/conversationClick'
@@ -301,9 +289,7 @@ export interface TabEventParams {
     tabId: string
 }
 
-export interface TabAddParams extends TabEventParams {
-    restoredTab?: boolean
-}
+export interface TabAddParams extends TabEventParams {}
 
 export interface TabChangeParams extends TabEventParams {}
 
@@ -420,15 +406,8 @@ export interface ContextCommandParams {
     contextCommandGroups: ContextCommandGroup[]
 }
 
-export interface PinnedContextParams extends ContextCommandParams {
-    tabId: string
-    textDocument?: TextDocumentIdentifier
-    showRules?: boolean
-}
-
 export interface CreatePromptParams {
     promptName: string
-    isRule?: boolean
 }
 
 export interface ProgrammingLanguage {
@@ -502,51 +481,6 @@ export interface ListMcpServersParams {
     filter?: Record<string, FilterValue>
 }
 
-export interface ListRulesParams {
-    tabId: string
-}
-
-export interface ListRulesResult {
-    tabId: string
-    header?: { title: string }
-    filterOptions?: FilterOption[]
-    rules: RulesFolder[]
-}
-
-export interface RulesFolder {
-    folderName?: string
-    /**
-     * Represents the active state of the folder:
-     * - true: all rules in the folder are active
-     * - false: all rules in the folder are inactive
-     * - 'indeterminate': rules inside the folder have mixed active states (some active, some inactive),
-     *   similar to a parent checkbox in a nested checkbox list having an indeterminate state
-     */
-    active: boolean | 'indeterminate'
-    rules: Rule[]
-}
-
-export interface Rule {
-    active: boolean
-    name: string
-    id: string
-}
-
-export interface RuleClickParams {
-    tabId: string
-    type: 'folder' | 'rule'
-    id: string
-}
-
-export interface RuleClickResult extends RuleClickParams {
-    success: boolean
-}
-
-export interface ActiveEditorChangedParams {
-    cursorState?: CursorState[]
-    textDocument?: TextDocumentIdentifier
-}
-
 export interface ConversationsList {
     header?: { title: string }
     filterOptions?: FilterOption[]