@aws/language-server-runtimes depends on deprecated aws-sdk v2

[TrevorBurnham]

If you install the latest @aws/language-server-runtimes with visible postinstall script output (e.g. using npm's --foreground-scripts flag), you'll see this:

╔═════════════════════════════════════════════════╗
║ The AWS SDK for JavaScript (v2) will reach      ║
║ -> maintenance mode on September 8, 2024.       ║
║ -> end-of-support on September 8, 2025.         ║
║                                                 ║
║ To continue receiving updates to AWS services,  ║
║ bug fixes, and security updates please upgrade  ║
║ to AWS SDK for JavaScript (v3).                 ║
║                                                 ║
║ More info: https://a.co/cUPnyil                 ║
╚═════════════════════════════════════════════════╝

Sure enough, the package directly depends on aws-sdk v2.

Aside from the deprecation notice, using aws-sdk v2 adds a huge amount of code to downstream projects. The size of my node_modules/aws-sdk is 103 MB!

Interestingly, looking around the code it looks like this package is only used for types, so the simplest fix would be to move aws-sdk into devDependencies.

If I understand this code correctly, the purpose of those types is backward compatibility with aws-sdk v2, so an alternative option would be to release a new version that drops that backward compatibility.

[justinmk3]

looking around the code it looks like this package is only used for types, so the simplest fix would be to move aws-sdk into devDependencies.

Great idea!

[rahmaniaam]

The fix has been merged to main, thanks again for raising the issue!

[TrevorBurnham]

Just noticed that this was brought back by #535, which means I'm seeing the deprecation warning and the 103 MB dependency again. 😞

If you'll reopen this, I can try to send over a patch. Though from the text in #535, it's not clear to me what actually broke when it was moved to devDependencies. @suprajaven Can you elaborate on the problems you observed?

[TrevorBurnham]

I see the issue now: Without the aws-sdk dependency, the references to its types wouldn't resolve for package consumers without that dependency, potentially causing TypeScript errors for them.

I've opened a PR to take an alternative approach, replacing the deprecated 103MB dependency with a lighter-weight, non-deprecated alternative that includes all of the same type information: #668