fix: add file context override for inline completion #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewyuq
approved these changes
Aug 11, 2025
Will-ShaoHua
approved these changes
Aug 11, 2025
leigaol
pushed a commit
that referenced
this pull request
Aug 12, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>language-server-runtimes: 0.2.125</summary> ## [0.2.125](language-server-runtimes/v0.2.124...language-server-runtimes/v0.2.125) (2025-08-12) ### Bug Fixes * add file context override for inline completion ([#660](#660)) ([f6f0da8](f6f0da8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Support of inline completion in JL Notebook is gone since the language server migration.
aws/aws-toolkit-vscode#7086
Solution
Let the IDE provide the file context.
There is a technical limitations of the language server that it cannot find or construct the
vscode.NotebookDocument,vscode.NotebookCell. Theworkspace.getTextDocumentdoes not work with JL Notebook as it gets a URI in the format of "vscode-notebook-cell:/../A1.ipynb#W2sZmlsZQ%3D%3D". The language server does not have the cell number, cell state, cursor position, etc of the current cell.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.