chore: emit telemetry for inline chat result (#1131)

* feat: change to emit STE event for inline chat action

* chore: add support for emitting telemetry related to inlineChatResult

* fix: fix merge conflict

* chore: remove the unused imports from TelemetryService class

---------

Co-authored-by: Paras <[email protected]>

Author: pras0131

server/aws-lsp-codewhisperer/src/language-server/agenticChat/agenticChatController.ts

@@ -1739,7 +1739,9 @@ export class AgenticChatController implements ChatHandlers {
         }
     }
 
-    async onInlineChatResult(handler: InlineChatResultParams) {}
+    async onInlineChatResult(params: InlineChatResultParams) {
+        await this.#telemetryService.emitInlineChatResultLog(params)
+    }
 
     async onCodeInsertToCursorPosition(params: InsertToCursorPositionParams) {
         // Implementation based on https://github.com/aws/aws-toolkit-vscode/blob/1814cc84228d4bf20270574c5980b91b227f31cf/packages/core/src/amazonq/commons/controllers/contentController.ts#L38

server/aws-lsp-codewhisperer/src/language-server/agenticChat/qAgenticChatServer.ts

@@ -155,6 +155,10 @@ export const QAgenticChatServer =
             return chatController.onButtonClick(params)
         })
 
+        chat.onInlineChatResult(params => {
+            return chatController.onInlineChatResult(params)
+        })
+
         logging.log('Q Chat server has been initialized')
 
         return () => {

server/aws-lsp-codewhisperer/src/language-server/chat/chatController.ts

@@ -285,7 +285,9 @@ export class ChatController implements ChatHandlers {
         }
     }
 
-    async onInlineChatResult(handler: InlineChatResultParams) {}
+    async onInlineChatResult(params: InlineChatResultParams) {
+        await this.#telemetryService.emitInlineChatResultLog(params)
+    }
 
     async onCodeInsertToCursorPosition(params: InsertToCursorPositionParams) {
         // Implementation based on https://github.com/aws/aws-toolkit-vscode/blob/1814cc84228d4bf20270574c5980b91b227f31cf/packages/core/src/amazonq/commons/controllers/contentController.ts#L38

server/aws-lsp-codewhisperer/src/language-server/chat/qChatServer.ts

@@ -116,6 +116,10 @@ export const QChatServerFactory =
             return chatController.onCodeInsertToCursorPosition(params)
         })
 
+        chat.onInlineChatResult(params => {
+            return chatController.onInlineChatResult(params)
+        })
+
         logging.log('Q Chat server has been initialized')
 
         return () => {

server/aws-lsp-codewhisperer/src/shared/telemetry/telemetryService.test.ts

@@ -907,4 +907,119 @@ describe('TelemetryService', () => {
             sinon.assert.notCalled(codeWhisperServiceStub.sendTelemetryEvent)
         })
     })
+
+    describe('Inline chat result notification', () => {
+        let telemetryService: TelemetryService
+        let mockCredentialsProvider: MockCredentialsProvider
+
+        beforeEach(() => {
+            mockCredentialsProvider = new MockCredentialsProvider()
+            mockCredentialsProvider.setConnectionMetadata({
+                sso: {
+                    startUrl: 'idc-start-url',
+                },
+            })
+
+            codeWhisperServiceStub.getCredentialsType.returns('bearer')
+            telemetryService = new TelemetryService(serviceManagerStub, mockCredentialsProvider, telemetry, logging)
+        })
+
+        afterEach(() => {
+            sinon.restore()
+        })
+
+        it('should send InlineChatEvent with correct parameters', () => {
+            const timestamp = new Date()
+            telemetryService.emitInlineChatResultLog({
+                requestId: 'mock-request-id',
+                inputLength: 10,
+                selectedLines: 2,
+                suggestionAddedChars: 20,
+                suggestionAddedLines: 3,
+                suggestionDeletedChars: 10,
+                suggestionDeletedLines: 2,
+                codeIntent: true,
+                userDecision: 'ACCEPT',
+                responseStartLatency: 1250,
+                responseEndLatency: 1500,
+                programmingLanguage: {
+                    languageName: 'typescript',
+                },
+            })
+
+            const expectedEvent = {
+                telemetryEvent: {
+                    inlineChatEvent: {
+                        requestId: 'mock-request-id',
+                        timestamp: timestamp,
+                        inputLength: 10,
+                        numSelectedLines: 2,
+                        numSuggestionAddChars: 20,
+                        numSuggestionAddLines: 3,
+                        numSuggestionDelChars: 10,
+                        numSuggestionDelLines: 2,
+                        codeIntent: true,
+                        userDecision: 'ACCEPT',
+                        responseStartLatency: 1250,
+                        responseEndLatency: 1500,
+                        programmingLanguage: {
+                            languageName: 'typescript',
+                        },
+                    },
+                },
+            }
+            sinon.assert.calledOnceWithExactly(codeWhisperServiceStub.sendTelemetryEvent, expectedEvent)
+        })
+
+        it('should not send InlineChatEvent when credentialsType is IAM', () => {
+            codeWhisperServiceStub.getCredentialsType.returns('iam')
+            telemetryService = new TelemetryService(serviceManagerStub, mockCredentialsProvider, telemetry, logging)
+            const timestamp = new Date()
+            telemetryService.emitInlineChatResultLog({
+                requestId: 'mock-request-id',
+                inputLength: 10,
+                selectedLines: 2,
+                suggestionAddedChars: 20,
+                suggestionAddedLines: 3,
+                suggestionDeletedChars: 10,
+                suggestionDeletedLines: 2,
+                codeIntent: true,
+                userDecision: 'ACCEPT',
+                responseStartLatency: 1250,
+                responseEndLatency: 1500,
+                programmingLanguage: {
+                    languageName: 'typescript',
+                },
+            })
+            sinon.assert.notCalled(codeWhisperServiceStub.sendTelemetryEvent)
+        })
+
+        it('should not send InlineChatEvent when login is BuilderID, but user chose OPTOUT option', () => {
+            mockCredentialsProvider.setConnectionMetadata({
+                sso: {
+                    startUrl: BUILDER_ID_START_URL,
+                },
+            })
+            telemetryService = new TelemetryService(serviceManagerStub, mockCredentialsProvider, telemetry, logging)
+            telemetryService.updateOptOutPreference('OPTOUT')
+            const timestamp = new Date()
+            telemetryService.emitInlineChatResultLog({
+                requestId: 'mock-request-id',
+                inputLength: 10,
+                selectedLines: 2,
+                suggestionAddedChars: 20,
+                suggestionAddedLines: 3,
+                suggestionDeletedChars: 10,
+                suggestionDeletedLines: 2,
+                codeIntent: true,
+                userDecision: 'ACCEPT',
+                responseStartLatency: 1250,
+                responseEndLatency: 1500,
+                programmingLanguage: {
+                    languageName: 'typescript',
+                },
+            })
+            sinon.assert.notCalled(codeWhisperServiceStub.sendTelemetryEvent)
+        })
+    })
 })

server/aws-lsp-codewhisperer/src/shared/telemetry/telemetryService.ts

@@ -18,6 +18,7 @@ import {
     TelemetryEvent,
     ChatAddMessageEvent,
     UserIntent,
+    InlineChatEvent,
 } from '../../client/token/codewhispererbearertokenclient'
 import { getCompletionType, getSsoConnectionType, isAwsError } from '../utils'
 import {
@@ -34,6 +35,7 @@ import {
 import { CodewhispererLanguage, getRuntimeLanguage } from '../languageDetection'
 import { CONVERSATION_ID_METRIC_KEY } from '../../language-server/chat/telemetry/chatTelemetryController'
 import { AmazonQBaseServiceManager } from '../amazonQServiceManager/BaseAmazonQServiceManager'
+import { InlineChatResultParams } from '@aws/language-server-runtimes/protocol'
 
 export class TelemetryService {
     // Using Base service manager here to support fallback cases such as in codeWhispererServer
@@ -530,4 +532,29 @@ export class TelemetryService {
             chatAddMessageEvent: event,
         })
     }
+
+    public emitInlineChatResultLog(params: InlineChatResultParams) {
+        const event: InlineChatEvent = {
+            requestId: params.requestId,
+            timestamp: new Date(),
+            inputLength: params.inputLength,
+            numSelectedLines: params.selectedLines,
+            numSuggestionAddChars: params.suggestionAddedChars,
+            numSuggestionAddLines: params.suggestionAddedLines,
+            numSuggestionDelChars: params.suggestionDeletedChars,
+            numSuggestionDelLines: params.suggestionDeletedLines,
+            codeIntent: params.codeIntent,
+            userDecision: params.userDecision,
+            responseStartLatency: params.responseStartLatency,
+            responseEndLatency: params.responseEndLatency,
+        }
+        if (params.programmingLanguage) {
+            event.programmingLanguage = {
+                languageName: getRuntimeLanguage(params.programmingLanguage.languageName as CodewhispererLanguage),
+            }
+        }
+        return this.invokeSendTelemetryEvent({
+            inlineChatEvent: event,
+        })
+    }
 }