fix: return QModelResponse as a response not an error (#1523)

* fix: for QModelResponse we sent the error as a response from Flare not leaving IDE to catch the error and then show on the chat UI

* fix: leave a message to notify to do tasks

* fix: move the return response in handleErrors to leave the telemetry

* fix: remove unused code and delete throw error throttling code

* fix: test related q model related response

* fix: store the chat response in a variable

* fix: change the error message based on new figma design

Author: XiaoxuanLu

server/aws-lsp-codewhisperer/src/language-server/agenticChat/agenticChatController.test.ts

@@ -1023,9 +1023,8 @@ describe('AgenticChatController', () => {
             )
 
             // These checks will fail if a response error is returned.
-            const typedChatResult = chatResult as ResponseError<ChatResult>
-            assert.strictEqual(typedChatResult.message, errorMsg)
-            assert.strictEqual(typedChatResult.data?.body, errorMsg)
+            const typedChatResult = chatResult as ChatResult
+            assert.strictEqual(typedChatResult.body, errorMsg)
         })
 
         it('truncate input to 500k character ', async function () {

server/aws-lsp-codewhisperer/src/language-server/agenticChat/agenticChatController.ts

@@ -1992,17 +1992,20 @@ export class AgenticChatController implements ChatHandlers {
                 // Clear the chat history in the database for this tab
                 this.#chatHistoryDb.clearTab(tabId)
             }
-
             const errorBody =
                 err.code === 'QModelResponse' && requestID
                     ? `${err.message} \n\nRequest ID: ${requestID} `
                     : err.message
-            return new ResponseError<ChatResult>(LSPErrorCodes.RequestFailed, err.message, {
+            const responseData: ChatResult = {
                 type: 'answer',
                 body: errorBody,
                 messageId: errorMessageId,
                 buttons: [],
-            })
+            }
+            if (err.code === 'QModelResponse') {
+                return responseData
+            }
+            return new ResponseError<ChatResult>(LSPErrorCodes.RequestFailed, err.message, responseData)
         }
         this.#features.logging.error(`Unknown Error: ${loggingUtils.formatErr(err)}`)
         return new ResponseError<ChatResult>(LSPErrorCodes.RequestFailed, err.message, {

server/aws-lsp-codewhisperer/src/language-server/chat/chatSessionService.ts

@@ -179,7 +179,7 @@ export class ChatSessionService {
                     error.message ===
                         'Encountered unexpectedly high load when processing the request, please try again.'
                 ) {
-                    error.message = ` The model you've selected is temporarily unavailable. Please select Auto or a different model and try again.`
+                    error.message = `The model you selected is temporarily unavailable. Please switch to a different model and try again.`
                 }
                 throw error
             }