fix: enforce MAX_TOOL_NAME_LENGTH check in createNamespacedToolName (#2447)

Author: ashishrp-aws

server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/mcp/mcpUtils.test.ts

@@ -543,6 +543,17 @@ describe('createNamespacedToolName', () => {
             toolName: longTool,
         })
     })
+
+    it('truncates tool name and adds suffix when it exceeds MAX_TOOL_NAME_LENGTH', () => {
+        const longTool = 'Smartanalyzerthatreadssummariescreatesmappingrulesandupdatespayloads'
+        const result = createNamespacedToolName('ConnectiveRx', longTool, tools, toolNameMapping)
+        expect(result.length).to.equal(MAX_TOOL_NAME_LENGTH)
+        expect(tools.has(result)).to.be.true
+        expect(toolNameMapping.get(result)).to.deep.equal({
+            serverName: 'ConnectiveRx',
+            toolName: longTool,
+        })
+    })
 })
 
 describe('normalizePathFromUri', () => {

server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/mcp/mcpUtils.ts

@@ -1168,8 +1168,8 @@ export function createNamespacedToolName(
     // Sanitize the tool name
     const sanitizedToolName = sanitizeName(toolName)
 
-    // First try to use just the tool name if it's not already in use
-    if (!allNamespacedTools.has(sanitizedToolName)) {
+    // First try to use just the tool name if it's not already in use and fits within length limit
+    if (sanitizedToolName.length <= MAX_TOOL_NAME_LENGTH && !allNamespacedTools.has(sanitizedToolName)) {
         allNamespacedTools.add(sanitizedToolName)
         toolNameMapping.set(sanitizedToolName, { serverName, toolName })
         return sanitizedToolName