fix: amazonqHistoryFileSize metric name case, add result

Author: avi-alpert

server/aws-lsp-codewhisperer/src/language-server/agenticChat/tabBarController.test.ts

@@ -81,8 +81,9 @@ describe('TabBarController', () => {
             sinon.assert.calledWith(telemetryService.emitChatHistoryAction as sinon.SinonStub, {
                 action: ChatHistoryActionType.Search,
                 languageServerVersion: testFeatures.runtime.serverInfo.version,
-                amazonQHistoryFileSize: undefined,
+                amazonqHistoryFileSize: undefined,
                 amazonqTimeToSearchHistory: 100,
+                result: 'Succeeded',
             })
         })
 
@@ -247,6 +248,7 @@ describe('TabBarController', () => {
             sinon.assert.calledWith(telemetryService.emitChatHistoryAction as sinon.SinonStub, {
                 action: ChatHistoryActionType.Open,
                 languageServerVersion: testFeatures.runtime.serverInfo.version,
+                result: 'Succeeded',
             })
         })
 
@@ -275,6 +277,7 @@ describe('TabBarController', () => {
             sinon.assert.calledWith(telemetryService.emitChatHistoryAction as sinon.SinonStub, {
                 action: ChatHistoryActionType.Delete,
                 languageServerVersion: testFeatures.runtime.serverInfo.version,
+                result: 'Succeeded',
             })
             assert.strictEqual(result.success, true)
         })
@@ -351,6 +354,7 @@ describe('TabBarController', () => {
                 action: ChatHistoryActionType.Export,
                 languageServerVersion: testFeatures.runtime.serverInfo.version,
                 filenameExt: 'markdown',
+                result: 'Succeeded',
             })
 
             assert.strictEqual(result.success, true)
@@ -424,6 +428,7 @@ describe('TabBarController', () => {
             sinon.assert.calledWith(telemetryService.emitExportTab as sinon.SinonStub, {
                 filenameExt: 'markdown',
                 languageServerVersion: testFeatures.runtime.serverInfo.version,
+                result: 'Succeeded',
             })
 
             assert.strictEqual(result.success, true)
@@ -484,8 +489,9 @@ describe('TabBarController', () => {
             sinon.assert.calledWith(telemetryService.emitLoadHistory as sinon.SinonStub, {
                 openTabCount: 2,
                 amazonqTimeToLoadHistory: -1,
-                amazonQHistoryFileSize: -1,
+                amazonqHistoryFileSize: -1,
                 languageServerVersion: testFeatures.runtime.serverInfo.version,
+                result: 'Succeeded',
             })
         })
 
@@ -503,8 +509,9 @@ describe('TabBarController', () => {
             sinon.assert.calledWith(telemetryService.emitLoadHistory as sinon.SinonStub, {
                 openTabCount: 1,
                 amazonqTimeToLoadHistory: -1,
-                amazonQHistoryFileSize: -1,
+                amazonqHistoryFileSize: -1,
                 languageServerVersion: testFeatures.runtime.serverInfo.version,
+                result: 'Succeeded',
             })
         })
 

server/aws-lsp-codewhisperer/src/language-server/agenticChat/tabBarController.ts

@@ -84,8 +84,9 @@ export class TabBarController {
                     this.#telemetryService.emitChatHistoryAction({
                         action: ChatHistoryActionType.Search,
                         languageServerVersion: this.#features.runtime.serverInfo.version,
-                        amazonQHistoryFileSize: dbSize,
+                        amazonqHistoryFileSize: dbSize,
                         amazonqTimeToSearchHistory: searchTime,
+                        result: 'Succeeded',
                     })
 
                     resolve(results)
@@ -162,12 +163,14 @@ export class TabBarController {
             this.#telemetryService.emitChatHistoryAction({
                 action: ChatHistoryActionType.Open,
                 languageServerVersion: this.#features.runtime.serverInfo.version,
+                result: 'Succeeded',
             })
         } else if (params.action === 'delete') {
             this.#chatHistoryDb.deleteHistory(historyID)
             this.#telemetryService.emitChatHistoryAction({
                 action: ChatHistoryActionType.Delete,
                 languageServerVersion: this.#features.runtime.serverInfo.version,
+                result: 'Succeeded',
             })
         } else if (params.action === 'export') {
             let openTabID = this.#chatHistoryDb.getOpenTabId(historyID)
@@ -192,6 +195,7 @@ export class TabBarController {
                 action: ChatHistoryActionType.Export,
                 languageServerVersion: this.#features.runtime.serverInfo.version,
                 filenameExt: format,
+                result: 'Succeeded',
             })
         } else {
             this.#features.logging.error(`Unsupported action: ${params.action}`)
@@ -208,6 +212,7 @@ export class TabBarController {
             this.#telemetryService.emitExportTab({
                 filenameExt: format,
                 languageServerVersion: this.#features.runtime.serverInfo.version,
+                result: 'Succeeded',
             })
 
             return { ...params, success: true }
@@ -279,9 +284,10 @@ export class TabBarController {
             }
             this.#telemetryService.emitLoadHistory({
                 amazonqTimeToLoadHistory: this.#chatHistoryDb.getLoadTime() ?? -1,
-                amazonQHistoryFileSize: this.#chatHistoryDb.getDatabaseFileSize() ?? -1,
+                amazonqHistoryFileSize: this.#chatHistoryDb.getDatabaseFileSize() ?? -1,
                 openTabCount: openConversations.length,
                 languageServerVersion: this.#features.runtime.serverInfo.version,
+                result: 'Succeeded',
             })
         }
     }

server/aws-lsp-codewhisperer/src/shared/telemetry/types.ts

@@ -283,21 +283,24 @@ export type UiClickEvent = {
 
 export type LoadHistoryEvent = {
     amazonqTimeToLoadHistory: number
-    amazonQHistoryFileSize: number
+    amazonqHistoryFileSize: number
     openTabCount: number
+    result: Result
     languageServerVersion?: string
 }
 
 export type ChatHistoryActionEvent = {
     action: ChatHistoryActionType
+    result: Result
     languageServerVersion?: string
     filenameExt?: string
     amazonqTimeToSearchHistory?: number
-    amazonQHistoryFileSize?: number
+    amazonqHistoryFileSize?: number
 }
 
 export type ExportTabEvent = {
     filenameExt: string
+    result: Result
     languageServerVersion?: string
 }