fix: add validation for empty chat history (#1403)

Author: Randall-Jiang

server/aws-lsp-codewhisperer/src/language-server/agenticChat/tools/chatDb/chatDb.ts

@@ -486,7 +486,7 @@ export class ChatDatabase {
     }
 
     private handleEmptyAssistantMessage(messages: Message[]): void {
-        if (messages.length === 0) {
+        if (messages.length < 2) {
             return
         }
 
@@ -573,62 +573,6 @@ export class ChatDatabase {
         return count
     }
 
-    private calculateCurrentMessageCharacterCount(message: Message): number {
-        let count = 0
-        // Count characters of message text
-        count += message.body.length
-
-        // Count characters in tool uses
-        if (message.toolUses) {
-            try {
-                for (const toolUse of message.toolUses) {
-                    count += JSON.stringify(toolUse).length
-                }
-            } catch (e) {
-                this.#features.logging.error(`Error counting toolUses: ${String(e)}`)
-            }
-        }
-        // Count characters in tool results
-        if (message.userInputMessageContext?.toolResults) {
-            try {
-                for (const toolResul of message.userInputMessageContext.toolResults) {
-                    count += JSON.stringify(toolResul).length
-                }
-            } catch (e) {
-                this.#features.logging.error(`Error counting toolResults: ${String(e)}`)
-            }
-        }
-        // Count characters in tool spec for the current user message
-        if (message.userInputMessageContext?.tools) {
-            try {
-                for (const toolSpec of message.userInputMessageContext.tools) {
-                    count += JSON.stringify(toolSpec).length
-                }
-            } catch (e) {
-                this.#features.logging.error(`Error counting tool spec length: ${String(e)}`)
-            }
-        }
-
-        if (message.userInputMessageContext?.additionalContext) {
-            try {
-                for (const addtionalContext of message.userInputMessageContext.additionalContext) {
-                    count += JSON.stringify(addtionalContext).length
-                }
-            } catch (e) {
-                this.#features.logging.error(`Error counting addtionalContext length: ${String(e)}`)
-            }
-        }
-
-        if (message.userInputMessageContext?.editorState) {
-            try {
-                count += JSON.stringify(message.userInputMessageContext?.editorState).length
-            } catch (e) {
-                this.#features.logging.error(`Error counting editorState length: ${String(e)}`)
-            }
-        }
-        return count
-    }
-
     ensureValidMessageSequence(messages: Message[], newUserMessage: ChatMessage): void {
         if (messages.length === 0) {
             return
@@ -646,6 +590,10 @@ export class ChatDatabase {
             this.#features.logging.debug('Dropped trailing user message')
         }
 
+        if (messages.length === 0) {
+            return
+        }
+
         //  Make sure there are alternating user and assistant messages
         const currentMessageType = chatMessageToMessage(newUserMessage).type
         const lastMessageType = messages[messages.length - 1].type
@@ -662,6 +610,13 @@ export class ChatDatabase {
         if (newUserMessage?.userInputMessage?.userInputMessageContext) {
             const newUserMessageContext = newUserMessage.userInputMessage.userInputMessageContext
             const toolResults = newUserMessageContext.toolResults || []
+            if (messages.length === 0) {
+                if (toolResults && toolResults.length > 0) {
+                    this.#features.logging.warn('New message has tool results but last message has no tool uses')
+                    return false
+                }
+                return true
+            }
             const lastMsg = messages[messages.length - 1]
             const lastMsgToolUses = lastMsg?.toolUses || []